feat: allow file:// protocol prefix in absolute paths#210
Open
laymonage wants to merge 1 commit intowebpack:mainfrom
Open
feat: allow file:// protocol prefix in absolute paths#210laymonage wants to merge 1 commit intowebpack:mainfrom
laymonage wants to merge 1 commit intowebpack:mainfrom
Conversation
|
|
laymonage
commented
Feb 17, 2026
Comment on lines
+332
to
+334
| createSuccessTestCase("absolutePath #7", { | ||
| testAbsolutePath: "file:///C:/directory/deep/tree", | ||
| }); |
Author
There was a problem hiding this comment.
I'm not sure if it's sufficient for Windows.
Seems OK based on nodejs/node#20080 and https://en.wikipedia.org/wiki/File_URI_scheme#Windows, but I haven't tested it myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #209
What kind of change does this PR introduce?
This allows an optional
file://protocol prefix for absolute paths, such as those returned byimport.meta.resolve().Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
Not that I know of.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
I couldn't find docs for the absolute path functions, so I didn't add any.