Conversation
tw4l
force-pushed
the
issue-3110-delete-bg-jobs-on-org-delete
branch
from
299eaef to
0d5aa1a
Compare
tw4l
force-pushed
the
issue-3110-delete-bg-jobs-on-org-delete
branch
2 times, most recently
from
65dc5fd to
c57ee5f
Compare
tw4l
force-pushed
the
issue-3110-delete-bg-jobs-on-org-delete
branch
from
7fed8cd to
c671625
Compare
- Only delete k8s resources in operator after job completes to prevent killing job before it has a chance to delete everything - Delete all background jobs from database except the delete org job so there's a record of the org having existed and so that tests can ensure deletion is successful - Ensure that all calls of delete_org_and_data method launch a background job for consistency - Don't delete org deletion background jobs from db in migration
ikreymer
force-pushed
the
issue-3110-delete-bg-jobs-on-org-delete
branch
from
8fa2437 to
a063d60
Compare
ikreymer
reviewed
Apr 15, 2026
|
|
||
| if not org.subscription.readOnlyOnCancel: | ||
| await self.org_ops.delete_org_and_data(org, self.user_manager) | ||
| await self.org_ops.background_job_ops.create_delete_org_job(org) |
ikreymer
approved these changes
Apr 15, 2026
Member
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
looks good, tested on dev as well.
ikreymer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3110
*The one exception is the background job to the delete the org itself - we don't want to delete the database record for the job while the job is actively running, and it seems reasonable to keep this one job in the database as a record that the org once existed.
To follow merging of #3111, before #3113