wet-366 Create Working Examples for Utilities/Helpers: Forms (GCWeb) #2234

hongbinyu413 · 2023-08-23T13:55:37Z

No description provided.

duboisp

Some additional change required

duboisp · 2024-02-12T18:58:42Z

common/utilities/helpers/index.json-ld

+		"fr": "Les éléments HTML utilisé tel quel."
+	},
+	"modified": "2023-02-21",
+	"componentName": "Utilities",


Suggested change

"componentName": "Utilities",

"componentName": "utilities",

duboisp · 2024-02-12T18:59:49Z

common/utilities/helpers/index.json-ld

+			{
+				"title": "Forms",
+				"language": "en",
+				"path": "forms.html"


Suggested change

"path": "forms.html"

"path": "helpers/forms.html"

duboisp · 2024-02-12T18:59:57Z

common/utilities/helpers/index.json-ld

+			{
+				"title": "Formulaires",
+				"language": "fr",
+				"path": "formulaires.html"


Suggested change

"path": "formulaires.html"

"path": "helpers/formulaires.html"

duboisp · 2024-02-12T19:01:41Z

common/utilities/helpers/index.json-ld

This index.json-ld need to be one level up, Here: common/utilities/

duboisp · 2024-02-12T19:09:32Z

common/utilities/helpers/forms.html

Missing the following modifier as a static example and a few more. Check the project card for all the CSS that need to be demoed:

has-success

…ilities/index.json-ld

https://getbootstrap.com/docs/3.4/css/#forms-control-validation

…html

…formulaires.html

duboisp

Remove the merge commit
Fix the content structure as commented inline
Fix the lint spacing issue

duboisp · 2024-03-13T20:41:48Z

common/utilities/forms.html

+<code class="language-html" data-lang="html">
+&lt;input class="form-control input-lg" type="datetime" placeholder=".form-control .input-lg" />
+&lt;input class="form-control" type="datetime-local" placeholder="Default input" />
+&lt;input class="form-control input-sm" type="date" placeholder=".form-control .input-sm" />
+&lt;input class="form-control input-lg" type="month" placeholder=".form-control .input-lg" />
+&lt;input class="form-control" type="datetime-time" placeholder="Default input" />
+&lt;input class="form-control input-sm" type="week" placeholder=".form-control .input-sm" />
+</code>


Suggested change

<code class="language-html" data-lang="html">

<input class="form-control input-lg" type="datetime" placeholder=".form-control .input-lg" />

<input class="form-control" type="datetime-local" placeholder="Default input" />

<input class="form-control input-sm" type="date" placeholder=".form-control .input-sm" />

<input class="form-control input-lg" type="month" placeholder=".form-control .input-lg" />

<input class="form-control" type="datetime-time" placeholder="Default input" />

<input class="form-control input-sm" type="week" placeholder=".form-control .input-sm" />

</code>

<pre><code class="language-html" data-lang="html">

<input class="form-control input-lg" type="datetime" placeholder=".form-control .input-lg" />

<input class="form-control" type="datetime-local" placeholder="Default input" />

<input class="form-control input-sm" type="date" placeholder=".form-control .input-sm" />

<input class="form-control input-lg" type="month" placeholder=".form-control .input-lg" />

<input class="form-control" type="datetime-time" placeholder="Default input" />

<input class="form-control input-sm" type="week" placeholder=".form-control .input-sm" />

</code></pre>

duboisp · 2024-03-13T20:41:58Z

common/utilities/forms.html

+<input class="form-control input-sm" type="week" placeholder=".form-control .input-sm" />
+</div>
+
+<br/>


Suggested change

<br/>

duboisp · 2024-03-13T20:42:26Z

common/utilities/forms.html

+<br/>
+
+
+<strong>input type: datetime</strong>


Suggested change

<strong>input type: datetime</strong>

<h4>input type: datetime</h4>

duboisp · 2024-03-13T20:46:35Z

common/utilities/forms.html

+	</label>
+</div>
+
+<div class="prettyprint prettyprinted"><pre><code class="language-html" data-lang="html">&lt;div class="checkbox"&gt;


Suggested change

<div class="prettyprint prettyprinted"><pre><code class="language-html" data-lang="html"><div class="checkbox">

<pre class="prettyprint prettyprinted"><code class="language-html" data-lang="html"><div class="checkbox">

duboisp

@AtlakM
Missing the example for the following CSS style:

.form-control-static https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_forms.scss#L298-L311
.form-group-sm - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_forms.scss#L314-L372
.form-group-lg - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_forms.scss#L314-L372
Checkbox and radio options - with [data-toggle="buttons"] - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_button-groups.scss#L222
Missing a few input-group example (input-group-sm input-group-lg) - See the CSS here - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_input-groups.scss
btn-group-xs btn-group-sm btn-group-lg - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_button-groups.scss#L96-L98
btn-group-justified - https://github.com/twbs/bootstrap-sass/blob/6b0ca5025c64f2e5696c8719cfce7148c78d0a50/assets/stylesheets/bootstrap/_button-groups.scss#L96-L98
an example that show the use of gc-font-2019 that wrap a whole form -

GCWeb/sites/baseline/_forms.scss

Line 42 in 8e3a4f0

// Apply the new font size to form, for early adopter

hongbinyu413 had a problem deploying to github-ci August 23, 2023 13:55 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from cd99368 to f07256c Compare August 24, 2023 14:10

hongbinyu413 had a problem deploying to github-ci August 24, 2023 14:10 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from f07256c to 99fabde Compare August 24, 2023 15:15

hongbinyu413 had a problem deploying to github-ci August 24, 2023 15:15 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from 99fabde to f776969 Compare August 24, 2023 15:42

hongbinyu413 had a problem deploying to github-ci August 24, 2023 15:42 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from f776969 to 4ed9e75 Compare August 24, 2023 16:16

hongbinyu413 had a problem deploying to github-ci August 24, 2023 16:17 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from 4ed9e75 to 7151f22 Compare August 24, 2023 17:11

hongbinyu413 had a problem deploying to github-ci August 24, 2023 17:12 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from 7151f22 to 967c9c9 Compare August 24, 2023 18:44

hongbinyu413 had a problem deploying to github-ci August 24, 2023 18:44 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from 967c9c9 to 8456e6a Compare August 24, 2023 19:10

hongbinyu413 had a problem deploying to github-ci August 24, 2023 19:11 — with GitHub Actions Failure

hongbinyu413 force-pushed the wet-366 branch from 8456e6a to 5d982c1 Compare August 24, 2023 19:37

hongbinyu413 temporarily deployed to github-ci August 24, 2023 19:37 — with GitHub Actions Inactive

wet-366 Create Working Examples for Utilities/Helpers: Forms (GCWeb)

fa163ca

hongbinyu413 force-pushed the wet-366 branch from 5d982c1 to fa163ca Compare August 24, 2023 19:40

hongbinyu413 temporarily deployed to github-ci August 24, 2023 19:41 — with GitHub Actions Inactive

duboisp added the Query: Project item Part of a github project label Sep 21, 2023

duboisp requested changes Feb 12, 2024

View reviewed changes

duboisp assigned hongbinyu413 Feb 12, 2024

duboisp assigned AtlakM and unassigned hongbinyu413 Feb 29, 2024

AtlakM and others added 5 commits March 5, 2024 14:35

Update and rename common/utilities/helpers/index.json-ld to common/ut…

691bdbb

…ilities/index.json-ld

wet-366 Create Working Examples for Utilities/Helpers: Forms (GCWeb)

c4b2ada

Merge branch 'wet-366' of https://github.com/AtlakM/GCWeb into wet-366

73ac893

Update forms.html has-success

c61264f

Update forms.html with bs3.4 example

2258225

https://getbootstrap.com/docs/3.4/css/#forms-control-validation

AtlakM and others added 9 commits March 5, 2024 15:56

Update forms.html indentation

110c9ba

Update forms.html added icons

d5591e4

Delete common/utilities/helpers/index.json-ld

06a3ebf

Rename common/utilities/helpers/forms.html to common/utilities/forms.…

5a275ff

…html

Rename common/utilities/helpers/formulaires.html to common/utilities/…

339c3bd

…formulaires.html

components

5072d54

components

b462858

components

73a5153

fixes

66cf51b

duboisp had a problem deploying to github-ci March 13, 2024 20:29 — with GitHub Actions Failure

Update index.json-ld folder move

c072922

duboisp requested changes Mar 13, 2024

View reviewed changes

duboisp requested changes Mar 14, 2024

View reviewed changes

duboisp force-pushed the wet-366 branch from 66cf51b to c8252d7 Compare March 14, 2024 20:34

duboisp temporarily deployed to github-ci March 14, 2024 20:34 — with GitHub Actions Inactive

duboisp temporarily deployed to github-ci March 14, 2024 20:37 — with GitHub Actions Inactive

AtlakM added 3 commits March 19, 2024 15:01

some changes to pre

4f30be7

added form elements from wet-boew#2234 (review)

7ba7373

cosmetic changes

d16dfc5

duboisp force-pushed the wet-366 branch from c8252d7 to d16dfc5 Compare March 19, 2024 21:01

duboisp had a problem deploying to github-ci March 19, 2024 21:01 — with GitHub Actions Failure

duboisp assigned duboisp and unassigned AtlakM Mar 19, 2024

	"path": "formulaires.html"
	"path": "helpers/formulaires.html"

	<strong>input type: datetime</strong>
	<h4>input type: datetime</h4>

	<div class="prettyprint prettyprinted"><pre><code class="language-html" data-lang="html"><div class="checkbox">
	<pre class="prettyprint prettyprinted"><code class="language-html" data-lang="html"><div class="checkbox">

wet-366 Create Working Examples for Utilities/Helpers: Forms (GCWeb) #2234

Are you sure you want to change the base?

wet-366 Create Working Examples for Utilities/Helpers: Forms (GCWeb) #2234

Uh oh!

Conversation

hongbinyu413 commented Aug 23, 2023

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants