Kqueue - client Connect dialed the local bind addr, not the remote#182
Open
Vizit0r wants to merge 1 commit into
Open
Kqueue - client Connect dialed the local bind addr, not the remote#182Vizit0r wants to merge 1 commit into
Vizit0r wants to merge 1 commit into
Conversation
TKqueueCrossSocket._Connect built LSockAddr only for the preceding Bind() (address family + ALocalPort, address left zeroed), then passed that same LSockAddr to connect(). On the Kqueue backend (macOS/iOS/BSD) every client connection was therefore dialed to 0.0.0.0:ALocalPort instead of the resolved remote in AAddr, so all outbound connects failed. Pass the resolved remote (AAddr.ai_addr / ai_addrlen), matching TEpollCrossSocket._Connect in Net.CrossSocket.Epoll.pas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TKqueueCrossSocket._Connect built LSockAddr only for the preceding Bind() (address family + ALocalPort, address left zeroed), then passed that same LSockAddr to connect(). On the Kqueue backend (macOS/iOS/BSD) every client connection was therefore dialed to 0.0.0.0:ALocalPort instead of the resolved remote in AAddr, so all outbound connects failed.
Pass the resolved remote (AAddr.ai_addr / ai_addrlen), matching TEpollCrossSocket._Connect in Net.CrossSocket.Epoll.pas.