Iocp.Send - guard AConnection.Close in the WSASend-failed path#185
Open
Vizit0r wants to merge 1 commit into
Open
Iocp.Send - guard AConnection.Close in the WSASend-failed path#185Vizit0r wants to merge 1 commit into
Vizit0r wants to merge 1 commit into
Conversation
When WSASend fails synchronously (returns < 0 with an error other than WSA_IO_PENDING), the cleanup path freed the IO data, fired the failure callback, then called AConnection.Close unconditionally. In practice AConnection has been observed to be nil at that point, so the bare call AVs. Guard the Close with Assigned(AConnection) so the failure path stays safe regardless of what the callback or earlier state did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When WSASend fails synchronously (returns < 0 with an error other than WSA_IO_PENDING), the cleanup path freed the IO data, fired the failure callback, then called AConnection.Close unconditionally. In practice AConnection has been observed to be nil at that point, so the bare call AVs.
Guard the Close with Assigned(AConnection) so the failure path stays safe regardless of what the callback or earlier state did.