android: fix custom top bar button measurement#8320
Open
yedidyak wants to merge 3 commits into
Open
Conversation
artald
previously approved these changes
Jun 1, 2026
artald
approved these changes
Jun 1, 2026
artald
approved these changes
Jun 1, 2026
noomorph
approved these changes
Jun 1, 2026
artald
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AT_MOSTspecs instead of forcing unspecified dimensions toactionBarSize.width/heightbehavior as exact dp sizing.Validation
git diff --check— passed.Not Run
cd playground/android && ./gradlew :react-native-navigation:testDebugUnitTest --tests '*TitleBarReactButtonView*' --tests '*TitleAndButtonsContainerTest*'— blocked becausenode_modules/@react-native/gradle-pluginis missing in this checkout.yarn install --immutable— attempted to restore dependencies, but Yarn failed during fetch with repeatedRequestError EBADF, so local Android unit tests could not be started.Risks
48dpexact sizing when no dimensions were provided.Review Context
UNSPECIFIED, but restores intrinsic-width behavior so buttons do not unnecessarily shrink the title area.actionBarSizewhen the parent provides no height; width falls back to screen width only as a non-zero bound.Suggested Reviewers