ML-KEM: fix comments, API signatures, minor issues#10405
Merged
dgarske merged 1 commit intowolfSSL:masterfrom May 7, 2026
Merged
ML-KEM: fix comments, API signatures, minor issues#10405dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
|
Frauschi
approved these changes
May 6, 2026
More checks for public or private key not set. wc_MlKemKey_Free clears key->flags wc_MlKemKey_DecodePrivateKey now checks the public key is valid. wc_MlKemKey_EncodePrivateKey doesn't need calculate hash of public key as encoding the public key will do this. EncodePrivateKey/EncodePublicKey now return BAD_STATE_E when flags not set. mlkem_kdf, mlkem_check_public, mlkem_xof_absorb pointer parameters are now const. Now all mlkem_redistribute_*_rand_avx2 functions are WOLFSSL_LOCAL. Changed Kyber uses to MlKem.
Contributor
Author
|
Re-based for the Python test fixes. |
dgarske
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More checks for public or private key not set.
wc_MlKemKey_Free clears key->flags
wc_MlKemKey_DecodePrivateKey now checks the public key is valid. wc_MlKemKey_EncodePrivateKey doesn't need calculate hash of public key as encoding the public key will do this.
EncodePrivateKey/EncodePublicKey now return BAD_STATE_E when flags not set.
mlkem_kdf, mlkem_check_public, mlkem_xof_absorb pointer parameters are now const.
Now all mlkem_redistribute_*_rand_avx2 functions are WOLFSSL_LOCAL. Changed Kyber uses to MlKem.
Testing
Tested ML-KEM still works.