Skip to content

Rust wrapper: add mlkem module #9833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
holtrop-wolfssl wants to merge 3 commits into
base: master
Choose a base branch
from
+1,138 −0
Draft

Rust wrapper: add mlkem module #9833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67c500e
Rust wrapper: add mlkem module
holtrop-wolfssl Feb 25, 2026
4235fa5
Add comments explaining ct.len() and ss.len() checks
holtrop-wolfssl Feb 26, 2026
d12285c
Rust wrapper: mlkem: update ss buffer length requirement comment
holtrop-wolfssl Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/rust-wrapper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
'',
'--enable-all',
'--enable-all --enable-dilithium',
'--enable-all --enable-mlkem',
'--enable-cryptonly --disable-examples',
'--enable-cryptonly --disable-examples --disable-aes --disable-aesgcm',
'--enable-cryptonly --disable-examples --disable-aescbc',
Expand Down
3 changes: 3 additions & 0 deletions wrapper/rust/wolfssl-wolfcrypt/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ fn scan_cfg() -> Result<()> {
check_cfg(&binding, "DILITHIUM_SEED_SZ", "dilithium_make_key_seed_sz");
check_cfg(&binding, "DILITHIUM_RND_SZ", "dilithium_rnd_sz");

/* mlkem / ML-KEM */
check_cfg(&binding, "wc_MlKemKey_Init", "mlkem");
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mlkem feature detection is keyed off wc_MlKemKey_Init, but the Rust wrapper uses wc_MlKemKey_New, wc_MlKemKey_Delete, wc_MlKemKey_MakeKey, etc. If wc_MlKemKey_Init isn’t present in a given wolfSSL build (or differs by version), cfg(mlkem) may not be set even though the functions actually used by the wrapper are available. Use a symbol that the wrapper directly relies on (e.g., wc_MlKemKey_New or wc_MlKemKey_MakeKey) for the check_cfg probe.

Suggested change
check_cfg(&binding, "wc_MlKemKey_Init", "mlkem");
check_cfg(&binding, "wc_MlKemKey_New", "mlkem");

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@holtrop-wolfssl holtrop-wolfssl Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this. If wc_MlKemKey_Init() is defined then _New(), etc... are defined as well.


/* sha */
check_cfg(&binding, "wc_InitSha", "sha");
check_cfg(&binding, "wc_InitSha224", "sha224");
Expand Down
1 change: 1 addition & 0 deletions wrapper/rust/wolfssl-wolfcrypt/headers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@
#include "wolfssl/wolfcrypt/aes.h"
#include "wolfssl/wolfcrypt/pwdbased.h"
#include "wolfssl/wolfcrypt/dilithium.h"
#include "wolfssl/wolfcrypt/mlkem.h"
1 change: 1 addition & 0 deletions wrapper/rust/wolfssl-wolfcrypt/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ pub mod fips;
pub mod hkdf;
pub mod hmac;
pub mod kdf;
pub mod mlkem;
pub mod prf;
pub mod random;
pub mod rsa;
Expand Down
Loading