Open
Conversation
padelsbach
force-pushed
the
padelsbach/finding-23
branch
from
19102a0 to
0c31782
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CRL fallback code was found to be unreachable in
internal.cdue to return code checking.CERT_UNKNOWNstatus for both leaf and non-leaf (intermediate) certificate paths inProcessPeerCerts().CERT_UNKNOWN, covering the leaf path and the non-leaf (OCSP_CHECKALL+CRL_CHECKALL) pathCERT_UNKNOWNsupport to the Python OCSP test blob generator and new test cert/CRL artifactsTesting
Added new tests to exercise the CRL fallback for both intermediate and leaf certs, and generation scripts.
Checklist