Re-enable hostap tests and remove some flaky tests#9841
Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Re-enable hostap tests and remove some flaky tests#9841julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Set suites->setSuites to 1 in ParseCipherList function
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the hostap/wpa-supplicant GitHub Actions workflow on push/PR and adjusts cipher suite parsing behavior to mark default suites as explicitly set, while also removing a subset of flaky hostap tests.
Changes:
- Set
suites->setSuiteswhen falling back to the wolfSSL default cipher list. - Re-enable the
hostap-vmworkflow forpushandpull_requestevents and expand the certificate regeneration step. - Remove several flaky tests from pinned hostap config test lists.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/internal.c | Marks the default cipher suite list as “set” when ParseCipherList falls back to wolfSSL defaults. |
| .github/workflows/hostap-vm.yml | Re-enables CI triggers and updates the order/steps for regeneration of hostap auth_serv certs. |
| .github/workflows/hostap-files/configs/b607d2723e927a3446d89aed813f1aa6068186bb/tests | Removes specific flaky tests from this pinned hostap test list. |
| .github/workflows/hostap-files/configs/07c9f183ea744ac04585fb6dd10220c75a5e2e74/tests | Removes specific flaky tests from this pinned hostap test list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set suites->setSuites to 1 in ParseCipherList function