hpke: add missing ForceZero for eae_prk, key_schedule_context, secret.#9894
Open
philljj wants to merge 1 commit intowolfSSL:masterfrom
Open
hpke: add missing ForceZero for eae_prk, key_schedule_context, secret.#9894philljj wants to merge 1 commit intowolfSSL:masterfrom
philljj wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit zeroization of HPKE intermediate secrets before freeing to reduce sensitive data lifetime in memory (Fixes F-280).
Changes:
- Zeroize
eae_prkafter use inwc_HpkeExtractAndExpand. - Zeroize
key_schedule_contextandsecretbefore freeing inwc_HpkeKeyScheduleBase. - Minor control-flow formatting change (adds braces) around the
ret == 0block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please. |
1 similar comment
Contributor
Author
|
Retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hpke: add missing ForceZero for eae_prk, key_schedule_context, secret.
Fixes F-280.