Make sure size check doesn't underflow#9914
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents an unsigned-size underflow when computing TLS 1.3 plaintext size by guarding the subtraction with a bounds check.
Changes:
- Adds a conditional check to ensure
curSize - aead_mac_sizeis only computed when safe. - Keeps existing TLS 1.3 encrypted and plaintext maximum-size enforcement logic intact.
Comments suppressed due to low confidence (1)
src/internal.c:1
- To make the intent clearer and avoid skipping the safe equality case, consider expressing the guard as
if (ssl->curSize >= ssl->specs.aead_mac_size)(or equivalentlyif (ssl->curSize > ssl->specs.aead_mac_size)if you intentionally want to skip equality) and prefer comparing the left-hand side ascurSizeto match the subtraction order. This reduces cognitive load when reading the bounds check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-30