Add MediaUploader actor with broadcast queue lifecycle#25621
Draft
crazytonyli wants to merge 4 commits into
Draft
Add MediaUploader actor with broadcast queue lifecycle#25621crazytonyli wants to merge 4 commits into
crazytonyli wants to merge 4 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
f85702c to
fde43a0
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
0e6ecbf to
d4572b8
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33050 | |
| Version | PR #25621 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6bb0246 | |
| Installation URL | 7ol27sapfbsq0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33050 | |
| Version | PR #25621 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6bb0246 | |
| Installation URL | 1iut3qgiqbnko |
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
d4572b8 to
8f96db5
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
fde43a0 to
323dddf
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
8f96db5 to
adab6df
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
323dddf to
56a1ac7
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
adab6df to
d4a7b1b
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
56a1ac7 to
7e76794
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
2 times, most recently
from
e91673a to
db8160b
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
710c2aa to
3bfae1c
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
3bfae1c to
610e467
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
2 times, most recently
from
fb748dd to
675d2da
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
610e467 to
0c14222
Compare
MediaSourceMaterializing lets the uploader talk to materialization through a protocol so tests can substitute a mock; TestSupport carries the fakes and fixtures the uploader tests share.
Serial upload queue that materializes each source, drives the transport, broadcasts pending/failed/uploaded state to observers, and supports per-item and bulk retry/cancel, with unit tests. Transport cancellations that arrive while the row is still present surface as retryable failures, and a retry whose staged file was purged while the app was suspended degrades to a clear dismiss-only file-not-found failure instead of an opaque transport error. The uploader refuses new work after tearDown and cancels in-flight tasks from deinit so publisher iterations always terminate. A public staging-orphan sweep lets the app clear leftover staged files at launch.
The uploader baked its policy into the materializer at init, so settings changed after creation (like Remove Location) never applied for the uploader's lifetime. updatePolicy(_:) swaps in a fresh materializer for future enqueues while in-flight work keeps the materializer its task captured at enqueue time.
MaterializedUpload now derives displayName from the temp file URL.
crazytonyli
force-pushed
the
task/media-v2-upload-materializer
branch
from
0c14222 to
f548d7a
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
675d2da to
6bb0246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25620.