-
Notifications
You must be signed in to change notification settings - Fork 25
[POP-2513] Make mask shares full length again #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bgillesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this review as a Comment to help avoid accidental merge, but the PR looks fine to me. I can't speak to all of the changes in iris-mpc-gpu, but the changes in iris-mpc-cpu seem to cover all of the relevant touch points with the mask shares.
| IRIS_CODE_LENGTH, | ||
| ); | ||
|
|
||
| // Pad partial mask if needed, since the DB may contain partial masks, where the imaginary and real parts are the same and deduplicated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this handling here we can continue without performing any migration for the existing mask codes right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the DB masks, yes, however the S3 ones have hard-coded length checks that are now wrong and will need some handling
This is in preperation for the fragile bits effort for iris codes. Up until now, mask code shares have had the same imaginary and real part, which meant that we could reduce the storage and memory costs by only storing half and multiplying the results by 2. This PR extends them to the full length again, such that future iris codes may have different real and imaginary parts.
The DB and S3 loader are modified in a way that they extend half-sized mask codes to full ones if needed.
Also: DO NOT MERGE FOR NOW, this may need some sync for correct DB exporting in future.
Impact of merging this: