Add battery voltage read #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Finally getting around to this. I'd like to look into sending this via a separate tag with an update to halsim_xrp in allwpilib that maps to ">vin_voltage" for the roboRIO simulation but need to add to XRP.h and some other files. Otherwise, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XRP robot has a battery voltage pin on it, but it was not configured to be read. I added that logic to support it.
I choose AnalogInput(3) as the channel in WpiLib to read the value. Ideally, it probably should have been hooked up to RobotController.getBatteryVoltage(), but I think that is a lot more infrastructure needed to do that.