Fix avx512vp cpuid#1355
Merged
Merged
Conversation
AntoinePrv
commented
May 21, 2026
Comment on lines
+860
to
+865
| inline bool avx_128() const noexcept | ||
| { | ||
| // Avx 128 bit instructions use the same xmm registers from SSE so checking if those | ||
| // are enabled is sufficient. | ||
| return sse_enabled() && leaf1().all_bits_set<x86_cpuid_leaf1::ecx::avx>(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Just adding a comment
AntoinePrv
commented
May 21, 2026
Comment on lines
+877
to
+882
| inline bool avx2_128() const noexcept | ||
| { | ||
| // Avx 128 bit instructions use the same xmm registers from SSE so checking if those | ||
| // are enabled is sufficient. | ||
| return sse_enabled() && leaf7().all_bits_set<x86_cpuid_leaf7::ebx::avx2>(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Same, this is just one extra comment
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will properly apply the chain
leaf1:osxsave->xcr0:[xy]mmWith proper default if
osxsaveis not set.Previously only this checks for saving
zmmregisters (avx512_enabled) so this would get deactivted every time 512 bits registers get deactivated (which would be one motivation for using smaller registers).@serge-sans-paille I think you might have gotten the first implementation wrong, no?