[fix] pstack and firefox #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern/imgact_elf will use ET_DYN_LOAD_ADDR as load address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fix allows to load information about shared libraries correctly if base address is ZERO and virtual load address is ZERO. kern/imgact_elf will use ET_DYN_LOAD_ADDR as load address (https://svnweb.freebsd.org/base/head/sys/kern/imgact_elf.c?revision=320481&view=markup#l895) in this case.
For testing purpose on 11.1 and 12-current, patch on libthr is required: https://reviews.freebsd.org/D11738
There are few cosmetic changes to improve verbose mode.