-
Notifications
You must be signed in to change notification settings - Fork 100
feat: Add keyctl support. Closes #103 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
…ment Add CLI documentation for direct keyring access across all platforms
Co-authored-by: alexec <[email protected]>
Co-authored-by: alexec <[email protected]>
|
@szuecs please can I request review. |
|
@ossenthusiast I asked Copilot and it says that does not survive reboots unfortunately. It does survive logins. I think it is the right direction. |
Co-authored-by: alexec <[email protected]>
|
@mikkeloscar please can I request your review on this PR? |
|
I am a bit biased against crap comments by AI machines. Can you cleanup all useless comments? |
Co-authored-by: alexec <[email protected]>
|
@szuecs copilot has addressed your comments. |
Co-authored-by: alexec <[email protected]>
|
@szuecs I've had Copilot move the composite provider to its own file and make the code easier to understand and revert the changes to existing comments. |
|
@szuecs can I please bump this to the top of your inbox? I'm hoping to use this on a project that will soon be ready to ship, but cannot run on dbus systems. It will only run where there is keyutils installed (headless systems). Thank you. |
|
@szuecs can I bump this please? For the moment, I'm going to release a fork of this. |
This adds support for
keyctl. This is only used if dbus does not work, otherwise it would break existing users.It is not persistent, i.e. reboots loose data. This is desirable for my use case.
Closes #103.