Skip to content

Conversation

@alexec
Copy link
Contributor

@alexec alexec commented Oct 17, 2025

This adds support for keyctl. This is only used if dbus does not work, otherwise it would break existing users.

It is not persistent, i.e. reboots loose data. This is desirable for my use case.

Closes #103.

@alexec
Copy link
Contributor Author

alexec commented Oct 17, 2025

@szuecs please can I request review.

@alexec alexec marked this pull request as ready for review October 17, 2025 15:06
@alexec
Copy link
Contributor Author

alexec commented Oct 18, 2025

@ossenthusiast I asked Copilot and it says that does not survive reboots unfortunately. It does survive logins. I think it is the right direction.

@alexec
Copy link
Contributor Author

alexec commented Oct 18, 2025

kitproj#1

@alexec
Copy link
Contributor Author

alexec commented Oct 20, 2025

@mikkeloscar please can I request your review on this PR?

@szuecs
Copy link
Member

szuecs commented Oct 23, 2025

I am a bit biased against crap comments by AI machines. Can you cleanup all useless comments?
Some are useful, but scrolling over the code I would say it's a lot useless.

@szuecs szuecs added the major moderate risk, for example new API, small changes that have no risk label Oct 23, 2025
@alexec
Copy link
Contributor Author

alexec commented Oct 29, 2025

@szuecs copilot has addressed your comments.

@alexec
Copy link
Contributor Author

alexec commented Oct 31, 2025

@szuecs I've had Copilot move the composite provider to its own file and make the code easier to understand and revert the changes to existing comments.

@alexec alexec requested a review from szuecs November 6, 2025 00:46
@alexec
Copy link
Contributor Author

alexec commented Nov 14, 2025

@szuecs can I please bump this to the top of your inbox? I'm hoping to use this on a project that will soon be ready to ship, but cannot run on dbus systems. It will only run where there is keyutils installed (headless systems).

Thank you.

@alexec
Copy link
Contributor Author

alexec commented Nov 22, 2025

@szuecs can I bump this please? For the moment, I'm going to release a fork of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major moderate risk, for example new API, small changes that have no risk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for keyutils

3 participants