feat: expose public type aliases from zarr.types#3886
Open
maxrjones wants to merge 1 commit intozarr-developers:mainfrom
Open
feat: expose public type aliases from zarr.types#3886maxrjones wants to merge 1 commit intozarr-developers:mainfrom
maxrjones wants to merge 1 commit intozarr-developers:mainfrom
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3886 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 87 87
Lines 11246 11253 +7
=======================================
+ Hits 10457 10464 +7
Misses 789 789
🚀 New features to boost your workflow:
|
Member
Author
Contributor
|
no you can keep this one open! that old PR is stale anyways. I just want to make sure we have all the related stuff here, so we can close those when it's resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many types used in Zarr's public API signatures (e.g. create_array, array indexing) are defined in internal modules like zarr.core.common, zarr.core.array, and zarr.core.indexing. Users who want to type-annotate their own code have to reach into zarr.core.*, which is not a stable API surface. This PR establishes zarr.types as the canonical public module for these types.
TODO:
docs/user-guide/*.mdchanges/