Skip to content

Conversation

@2400031598
Copy link

Added my profile entry in users.json

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha @2400031598 🙌
Thanks for your contribution !
I've observed few changes required in order to meet the contributions requirements.
Please address the provided feedback before we could move forwards :)

Happy coding 🚀


#3472 PR duplication ( closed )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, your changes don't meet our expectations on how to contribute to the folder.
I would highly advice you to double check the requirements in the README.md file

Here are feedback to address:

  • Folder addition src/components: Please remove the folder and its content
  • Incorrect File name within src/components:
    • Please rename your file as described in the README.md - make sure to have the correct extension
    • Please put your file in the correct folder ( described in the README.md )
  • Invalid content: Please refer to the "README.md" file for the content expected from you
    Note: as the README.md describes: if you don't want to fill specific properties, you need to provide an empty string value for the fields you are not using.

@sophiabrandt
Copy link
Member

@2400031598 are you still interested in adding your entry? If so, please fix the issues above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants