Skip to content

Added solution of 04_constants Closes #13 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmandeepMandal1077 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added solution of 04_constants Closes #13 #164

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc19e4
Added solution of 04_constants
AmandeepMandal1077 Oct 28, 2025
cd7288b
added comment
AmandeepMandal1077 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/exercises/solutions/04_constants/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package constants

import "math"

func CircleArea(r float64) float64 {
return math.Pi * r * r
}
Comment on lines +6 to +8
Copy link

@coderabbitai coderabbitai bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify edge case handling and test coverage.

The implementation is mathematically correct. However, please ensure that the behavior for edge cases is intentional and properly tested:

  • Negative radius: Currently returns a positive value (since r * r is positive). Is this the intended behavior, or should it validate that radius is non-negative?
  • Special float values: NaN and Inf will propagate through the calculation.
  • Zero radius: Correctly returns 0.

According to the PR objectives, edge cases should be included in tests. Please confirm that your test suite covers these scenarios appropriately.

Run the following script to check if tests exist and examine their coverage:

🏁 Script executed:

#!/bin/bash
# Description: Verify test file exists and check for edge case coverage

# Check if test file exists
fd -t f "constants_test.go" internal/exercises/solutions/04_constants/

# Display test content to verify edge case coverage
fd -t f "constants_test.go" internal/exercises/solutions/04_constants/ --exec cat {}

Length of output: 0

I need to explore the repository structure more broadly to locate test files.

🏁 Script executed:

#!/bin/bash
# Description: Explore repository structure and locate test files

# List directory structure for the constants exercise
echo "=== Directory structure for constants exercise ==="
fd . internal/exercises/solutions/04_constants/ -type f -o -type d

# Search for any test files in the exercises directory
echo -e "\n=== All test files in exercises directory ==="
fd -t f ".*test\.go$" internal/exercises/solutions/ 2>/dev/null | head -20

# Check if constants_test.go exists anywhere
echo -e "\n=== Search for constants_test.go anywhere in repo ==="
fd -t f "constants_test.go" 2>/dev/null

# List all Go files in 04_constants directory
echo -e "\n=== All Go files in 04_constants ==="
fd -t f "\.go$" internal/exercises/solutions/04_constants/

Length of output: 476

Now let me examine the test file in the templates directory:

🏁 Script executed:

#!/bin/bash
# Description: Examine the test file for CircleArea function

cat internal/exercises/templates/04_constants/constants_test.go

Length of output: 225

Expand test coverage to include edge cases and use table-driven tests.

The implementation is correct, but the test file at internal/exercises/templates/04_constants/constants_test.go contains only a single basic test case and does not align with the PR objective of including "edge cases and table-driven tests."

Current gaps:

  • Only one test case (radius = 2)
  • No edge case coverage (negative radius, zero, NaN, Inf)
  • Not using table-driven testing pattern

Expand constants_test.go to include multiple cases with a table-driven approach:

  • Valid positive values (e.g., 1, 2, 5)
  • Zero radius → expect 0
  • Negative radius → verify current behavior or add validation as appropriate
  • Special float values if they should be handled
🤖 Prompt for AI Agents 
In internal/exercises/solutions/04_constants/constants.go around lines 5 to 7,
the CircleArea implementation is fine but the tests in
internal/exercises/templates/04_constants/constants_test.go need to be expanded
into a table-driven test covering multiple cases: create a table with rows for
positive radii (1, 2, 5) comparing against expected computed areas, zero radius
(expect 0), negative radius (decide whether to assert current behavior e.g.,
area using same formula or add validation—use the current formula if
implementation won't change), and special float values (math.NaN(), math.Inf(1/
-1) ) with appropriate assertions (use math.IsNaN for NaN and math.IsInf for
infinities); iterate the table with t.Run subtests and compare floats with a
small epsilon for finite comparisons.

Loading