std.os.linux.IoUring: IORING_ENTER_NO_IOWAIT flag support#25604
Open
RaidoAun wants to merge 1 commit intoziglang:masterfrom
Open
std.os.linux.IoUring: IORING_ENTER_NO_IOWAIT flag support#25604RaidoAun wants to merge 1 commit intoziglang:masterfrom
RaidoAun wants to merge 1 commit intoziglang:masterfrom
Conversation
auto-merge was automatically disabled
October 17, 2025 09:31
Head branch was pushed to by a user without write access
RaidoAun
force-pushed
the
IORING_ENTER_NO_IOWAIT-flag-support-
branch
from
4cfa5b8 to
0080795
Compare
Author
|
@andrewrk it turns out that I made a mistake regarding the usage of flags, liburing introduced int_flags which we lacked. I thought we were using them as the flags field but turns out that was false. I added the int_flags field just like liburing has them. The only caveat is that liburing does some extra work to set the int_flags according to the setup flags, but since we seem to be behind liburing quite a bit then I do not think it is for this PR to also solve those issues. There should be a followup issue if there is a desire for this. Currently there is nothing inherently wrong since previously there just wasnt even the support to have persistent flags for enter, now atleast there are but they have to be set manually. |
RaidoAun
force-pushed
the
IORING_ENTER_NO_IOWAIT-flag-support-
branch
from
0080795 to
bb6b867
Compare
14 tasks
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 21, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 25, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Oct 27, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 3, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 3, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 7, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 13, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 14, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 17, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 20, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 21, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
bernardassan
added a commit
to bernardassan/zig
that referenced
this pull request
Nov 26, 2025
closes ziglang#25566 closes ziglang#25604 and IoUring enter_flags() helper function add typed Init flags which match int_flags in liburing Co-authored-by: RaidoAun <[email protected]> Signed-off-by: Bernard Assan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #25566
liburing changes:
axboe/liburing@8f0c124#diff-ddb623c7d8d649eff38f34b19b7a2f8b55e1d448ee94b813a9541d5304467629