Skip to content

Conversation

@Duguce
Copy link
Contributor

@Duguce Duguce commented Jul 8, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copilot AI review requested due to automatic review settings July 8, 2025 15:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated "memos" search path from the search_query function to prevent redundant branch logic.

  • Deleted the elif frame == "memos": branch.
  • Consolidated search framing to only "zep" and "mem0".

context, duration_ms = zep_search(client, query, conv_id, top_k)
elif frame == "memos":
context, duration_ms = memos_search(client, query)
elif frame == "mem0":
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the memos branch removed, passing frame="memos" will fall through and leave context and duration_ms uninitialized, causing a runtime error. Consider adding an else clause to explicitly handle unsupported frame values or raise a clear error.

Copilot uses AI. Check for mistakes.
@Ki-Seki
Copy link
Member

Ki-Seki commented Jul 8, 2025

This branch is out of date with the base branch. Please update it.


该分支与基础分支不同步,请更新它。

@Ki-Seki Ki-Seki self-requested a review July 8, 2025 15:57
@Duguce
Copy link
Contributor Author

Duguce commented Jul 9, 2025

@Ki-Seki have updated the branch.

@Ki-Seki Ki-Seki merged commit 73ac54e into MemTensor:dev Jul 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants