-
Notifications
You must be signed in to change notification settings - Fork 317
fix(eval): delete about memos redundant search branches #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated "memos" search path from the search_query function to prevent redundant branch logic.
- Deleted the
elif frame == "memos":branch. - Consolidated search framing to only
"zep"and"mem0".
| context, duration_ms = zep_search(client, query, conv_id, top_k) | ||
| elif frame == "memos": | ||
| context, duration_ms = memos_search(client, query) | ||
| elif frame == "mem0": |
Copilot
AI
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the memos branch removed, passing frame="memos" will fall through and leave context and duration_ms uninitialized, causing a runtime error. Consider adding an else clause to explicitly handle unsupported frame values or raise a clear error.
|
This branch is out of date with the base branch. Please update it. 该分支与基础分支不同步,请更新它。 |
|
@Ki-Seki have updated the branch. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist