Skip to content

fix(eval): delete about memos redundant search branches #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ki-Seki merged 11 commits into from
Jul 9, 2025
Merged

fix(eval): delete about memos redundant search branches #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4ef7418
feat(eval): add eval dependencies
Duguce Jul 7, 2025
ddad8c1
feat(eval): add configs example
Duguce Jul 7, 2025
d623791
docs(eval): update README.md
Duguce Jul 7, 2025
3365de4
Merge branch 'MemTensor:dev' into dev
Duguce Jul 8, 2025
ed68e36
feat(eval): remove the dependency (pydantic)
Duguce Jul 8, 2025
4e99031
Merge branch 'MemTensor:dev' into dev
Duguce Jul 8, 2025
41368b9
feat(eval): add run locomo eval script
Duguce Jul 8, 2025
9477539
Merge branch 'MemTensor:dev' into dev
Duguce Jul 8, 2025
8cd9361
fix(eval): delete about memos redundant search branches
Duguce Jul 8, 2025
a900910
chore: fix format
Duguce Jul 8, 2025
204bd27
Merge branch 'MemTensor:dev' into dev
Duguce Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions evaluation/scripts/locomo/locomo_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,6 @@ def search_query(client, query, metadata, frame, reversed_client=None, top_k=20)

if frame == "zep":
context, duration_ms = zep_search(client, query, conv_id, top_k)
elif frame == "memos":
context, duration_ms = memos_search(client, query)
elif frame == "mem0":
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the memos branch removed, passing frame="memos" will fall through and leave context and duration_ms uninitialized, causing a runtime error. Consider adding an else clause to explicitly handle unsupported frame values or raise a clear error.

Copilot uses AI. Check for mistakes.
context, duration_ms = mem0_search(
client, query, speaker_a_user_id, speaker_b_user_id, top_k
Expand Down
Empty file modified evaluation/scripts/run_locomo_eval.sh
100644 → 100755
View file
Open in desktop
Empty file.