fix: lint#103
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
9c071c7 to
a132eda
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a132eda. Configure here.
| "test": "vitest && attw --pack && yarn test:types", | ||
| "test": "vitest && yarn test:types", | ||
| "test:types": "tsd --files ./tests/index.test-d.ts", | ||
| "test:attw": "attw --pack", |
There was a problem hiding this comment.
Type-checking CI step silently dropped from test pipeline
High Severity
The attw --pack check was removed from the test script and moved to a new test:attw script, but test:attw is never called by any CI workflow or other script. The CI pipeline (.github/workflows/build-lint-test.yml) only runs yarn test, so the "Are the Types Wrong?" validation — which ensures published type definitions are correct for consumers — is now silently skipped in CI. This could allow broken type exports to be published.
Reviewed by Cursor Bugbot for commit a132eda. Configure here.


Note
Low Risk
Dev-only script and dependency changes with a trivial import reorder; no runtime library behavior changes.
Overview
Default
yarn testnow runs only Vitest. Package export checks (attw --pack) and declaration tests (tsd) move to dedicated scriptstest:attwandtest:types, which were previously chained intotest.@arethetypeswrong/cliis bumped from 0.17.4 to 0.18.2, with matching lockfile updates for@arethetypeswrong/coreand relatedlru-cacheresolution.Import order in
tests/index.test-d.tsis adjusted (Stellar before Tron) to satisfy lint/format rules.Reviewed by Cursor Bugbot for commit 8681faa. Bugbot is set up for automated code reviews on this repo. Configure here.