Skip to content

fix: lint #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adaOctopus merged 4 commits into from
May 26, 2026
+20 −19
Merged

fix: lint #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4459aa7
fix: lint
0xEdouardEth May 26, 2026
65a5a1e
fix: type test with node 22
0xEdouardEth May 26, 2026
7001a5d
fix: dedup
0xEdouardEth May 26, 2026
8681faa
fix: types tests
0xEdouardEth May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,13 @@
"lint:biome": "biome check",
"lint:fix": "yarn lint:biome --fix && yarn format:fix && yarn lint:constraints --fix && yarn lint:dependencies && yarn lint:changelog",
"prepack": "./scripts/prepack.sh",
"test": "vitest && attw --pack && yarn test:types",
"test": "vitest",
"test:types": "tsd --files ./tests/index.test-d.ts",
"test:attw": "attw --pack",
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type-checking CI step silently dropped from test pipeline

High Severity

The attw --pack check was removed from the test script and moved to a new test:attw script, but test:attw is never called by any CI workflow or other script. The CI pipeline (.github/workflows/build-lint-test.yml) only runs yarn test, so the "Are the Types Wrong?" validation — which ensures published type definitions are correct for consumers — is now silently skipped in CI. This could allow broken type exports to be published.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a132eda. Configure here.

"test:watch": "vitest --watch"
},
"devDependencies": {
"@arethetypeswrong/cli": "0.17.4",
"@arethetypeswrong/cli": "0.18.2",
"@biomejs/biome": "1.9.4",
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expectError, expectType } from 'tsd';
import { getMultichainClient } from '../src/index';
import type { Signature } from '../src/types/scopes/tron.types';
import type { StellarAddress } from '../src/types/scopes/stellar.types';
import type { Signature } from '../src/types/scopes/tron.types';
import { getMockTransport } from './mocks';

const client = getMultichainClient({ transport: getMockTransport() });
Expand Down
32 changes: 16 additions & 16 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ __metadata:
languageName: node
linkType: hard

"@arethetypeswrong/cli@npm:0.17.4":
version: 0.17.4
resolution: "@arethetypeswrong/cli@npm:0.17.4"
"@arethetypeswrong/cli@npm:0.18.2":
version: 0.18.2
resolution: "@arethetypeswrong/cli@npm:0.18.2"
dependencies:
"@arethetypeswrong/core": "npm:0.17.4"
"@arethetypeswrong/core": "npm:0.18.2"
chalk: "npm:^4.1.2"
cli-table3: "npm:^0.6.3"
commander: "npm:^10.0.1"
Expand All @@ -25,23 +25,23 @@ __metadata:
semver: "npm:^7.5.4"
bin:
attw: dist/index.js
checksum: 10/5309b7f0a35d8d9118f0bc658448112bfcc76e36a5bf1f237acc492cab56446902b3bdbb2f7b37506521edc722ac2a3c4e16227c8e4eece7c837573122f6c4bb
checksum: 10/8b4506edeb37d58f15e347302df68981c5aefecce973e746026d46370bb560c1ebc05ef8a38eba3102881df4cd3c901961186e3df41077efca4e58adffd455a1
languageName: node
linkType: hard

"@arethetypeswrong/core@npm:0.17.4":
version: 0.17.4
resolution: "@arethetypeswrong/core@npm:0.17.4"
"@arethetypeswrong/core@npm:0.18.2":
version: 0.18.2
resolution: "@arethetypeswrong/core@npm:0.18.2"
dependencies:
"@andrewbranch/untar.js": "npm:^1.0.3"
"@loaderkit/resolve": "npm:^1.0.2"
cjs-module-lexer: "npm:^1.2.3"
fflate: "npm:^0.8.2"
lru-cache: "npm:^10.4.3"
lru-cache: "npm:^11.0.1"
semver: "npm:^7.5.4"
typescript: "npm:5.6.1-rc"
validate-npm-package-name: "npm:^5.0.0"
checksum: 10/0aa5d8c21de977fdca3b79d25b07e9346b4b8f45ea95146c2b08961c8e0842326fb8879e9e1f001fadf132d9bede78a13df7974ca15cfb0a2e08000369b75c43
checksum: 10/9c3edeb8e09e572682e37f55bd523d0dad45388232d31fa1d8875f7f5c414a184070c2bb6d0c8f254dfce4ed9248da373d549ecdeaa571a0cfff04c387c94cf1
languageName: node
linkType: hard

Expand Down Expand Up @@ -882,7 +882,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@metamask/multichain-api-client@workspace:."
dependencies:
"@arethetypeswrong/cli": "npm:0.17.4"
"@arethetypeswrong/cli": "npm:0.18.2"
"@biomejs/biome": "npm:1.9.4"
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.0.0"
Expand Down Expand Up @@ -3621,17 +3621,17 @@ __metadata:
languageName: node
linkType: hard

"lru-cache@npm:^10.2.0, lru-cache@npm:^10.4.3":
"lru-cache@npm:^10.2.0":
version: 10.4.3
resolution: "lru-cache@npm:10.4.3"
checksum: 10/e6e90267360476720fa8e83cc168aa2bf0311f3f2eea20a6ba78b90a885ae72071d9db132f40fda4129c803e7dcec3a6b6a6fbb44ca90b081630b810b5d6a41a
languageName: node
linkType: hard

"lru-cache@npm:^11.0.0, lru-cache@npm:^11.1.0, lru-cache@npm:^11.2.1":
version: 11.2.4
resolution: "lru-cache@npm:11.2.4"
checksum: 10/3b2da74c0b6653767f8164c38c4c4f4d7f0cc10c62bfa512663d94a830191ae6a5af742a8d88a8b30d5f9974652d3adae53931f32069139ad24fa2a18a199aca
"lru-cache@npm:^11.0.0, lru-cache@npm:^11.0.1, lru-cache@npm:^11.1.0, lru-cache@npm:^11.2.1":
version: 11.5.0
resolution: "lru-cache@npm:11.5.0"
checksum: 10/c02af3d6e5e5baff9b52ed1a0850dc97e21a2554308c0feab5663873f9b395ea66b2767ead6e347542c08ab89b04aadb92884eddbcd14d975505687530df99e8
languageName: node
linkType: hard

Expand Down
Loading