feat(config): add support for environment variable placeholders in config #1031
Conversation
|
thanks for the PR what about adding some tests? |
thanks, I added some more tests |
|
if no question/feedback from anyone, i'll merge it tomorrow or this weekend. thanks again for the enhancement. |
|
Hey @wing328 , any news? 😀 |
|
can you please review the feedback in #1090 (comment) ? |
The issue should be addressed |
|
@cubic-dev-ai please review |
@wing328 I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/generator-cli/src/README.md">
<violation number="1" location="apps/generator-cli/src/README.md:204">
P3: Grammatical error: "has been replace" should be "has been replaced" (past participle form).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
thanks for the contribution. let's give it a try |
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
fixes #860
credits to @gonzalad for his PR #861