feat(config): add support for environment variable placeholders in config

[wing328]

Summary by cubic

Add environment variable placeholder support in openapitools.json so configs can reference ${VAR} or ${env.VAR} for dynamic values. Updated docs and tests to cover usage.

• New Features
  • Replaces placeholders in strings, arrays, and nested objects.
  • Logs an error and leaves the token unchanged when the env var is missing.
  • README: documents env. and placeholders for repository queryUrl/downloadUrl.
  • Adds unit tests for replacement behavior and edge cases.

^{Written for commit 5325b17. Summary will update automatically on new commits.}

based on #1031

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/generator-cli/src/app/services/config.service.ts">

<violation number="1" location="apps/generator-cli/src/app/services/config.service.ts:145">
P1: Calling `replacePlaceholders()` in `read()` will corrupt the config file when `set()` is used. The `set()` method calls `read()` to get the current config, modifies it, and writes it back. Since placeholders are now replaced during `read()`, the original `${VAR}` syntax will be permanently overwritten with resolved values. Consider applying placeholder replacement only in `get()` when returning values, not in `read()` which is also used for config modification.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Calling replacePlaceholders() in read() will corrupt the config file when set() is used. The set() method calls read() to get the current config, modifies it, and writes it back. Since placeholders are now replaced during read(), the original ${VAR} syntax will be permanently overwritten with resolved values. Consider applying placeholder replacement only in get() when returning values, not in read() which is also used for config modification.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/generator-cli/src/app/services/config.service.ts, line 145:

<comment>Calling `replacePlaceholders()` in `read()` will corrupt the config file when `set()` is used. The `set()` method calls `read()` to get the current config, modifies it, and writes it back. Since placeholders are now replaced during `read()`, the original `${VAR}` syntax will be permanently overwritten with resolved values. Consider applying placeholder replacement only in `get()` when returning values, not in `read()` which is also used for config modification.</comment>

<file context>
@@ -137,10 +137,57 @@ export class ConfigService {
       fs.readJSONSync(this.configFile, { throws: false, encoding: &#39;utf8&#39; }),
     );
+
+    return this.replacePlaceholders(config);
+  }
+
</file context>