-
Notifications
You must be signed in to change notification settings - Fork 106
[French Translation] First step review #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stop review at ligne 135 / <!-- Change record -->
|
Hello! Thank you very much for the help. Does "Stop review at ligne 135" mean that the PR is not ready yet? |
|
Your're welcomed, This PR is ready to be merged. The review will take me a long long time ... further PR to come (but not before 1 week or 2). |
|
Great work! Left few comments for discussion. |
|
Thanks a lot for your detailed review of this Merge Request 🙏. Several general remarks:
|
|
Hi, Sorry, I'm not to familiar with fork and branches within GitHub => I performed deletion of my old "patch-1" branch and it has automatically closed this PR ... Despite above discussion topics are still accurate, all my translation changes are to be seen here in a new PR => #421 |
Stop major review at line 135
/ <!-- Change record -->