Skip to content

Conversation

@ldmpub
Copy link

@ldmpub ldmpub commented Dec 29, 2025

  • add some missing strings
  • improve consistency (for instance: Record = Enregistrement ; Tag = Étiquette ...)
  • correct 'basic' errors

Stop major review at line 135
/ <!-- Change record -->

@Razeeman
Copy link
Owner

Hello! Thank you very much for the help.

Does "Stop review at ligne 135" mean that the PR is not ready yet?

@ldmpub
Copy link
Author

ldmpub commented Dec 30, 2025

Your're welcomed,

This PR is ready to be merged.

The review will take me a long long time ... further PR to come (but not before 1 week or 2).

@Razeeman
Copy link
Owner

Razeeman commented Jan 4, 2026

Great work! Left few comments for discussion.

@ldmpub
Copy link
Author

ldmpub commented Jan 4, 2026

Thanks a lot for your detailed review of this Merge Request 🙏.

Several general remarks:

  1. french translation of the app is yet of poor quality despite your awareness
  2. to ease and improve translation you may have a look to online translation tools. I personally strongly recommend using Weblate (link to my profile) ; Weblate offers a "free hosted solution" for FOSS project and is quite easy to operate with GitHub
  3. Question: is there a quick and easy way to get an updated apk to check new translations in context running the app?
  4. Personally, and since several years !, I'm trying to find an Android app to track my time during "my business" ... I will give this app a try during Q1 2026 but I already miss an easy way to track "vacation days".

@ldmpub
Copy link
Author

ldmpub commented Jan 4, 2026

Hi,

Sorry, I'm not to familiar with fork and branches within GitHub => I performed deletion of my old "patch-1" branch and it has automatically closed this PR ...

Despite above discussion topics are still accurate, all my translation changes are to be seen here in a new PR => #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants