-
Notifications
You must be signed in to change notification settings - Fork 107
[French Translation] Part 2 of n (n is unknown 🤣) #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Stop review at ligne 135 / <!-- Change record -->
<!-- Change record type -->
Stop at line 306 <!-- Settings -->
Just review not going ahead ...
|
Note for myself |
|
Cont from #417 (comment)
|
|
Hi, Regarding your answer: "3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash." 3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think? |
|
Regarding answer "4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it." |
Would be cool, unfortunately I don't know if Android development tools has this kind of automation.
It hasn't been run for a long time, and got broken, and was failing. Should be working now in dev branch. After the successful run, there will be an artifact available for download.
There is a duration format option, but it is global for all activities unfortunately. |
|
Also can I mention you in the app as a translator and what name should be used for this? |
No mention yet before I have performed a full review of the app translation and before I become, hopefully, a daily user of the app🤞. |
Current Status:
|
'balise' replaced by 'étiquette' ... brut (but yet manual 😉) search and replace.
Updated French strings for better clarity and consistency.
Sorry for the confusion, it should be run from your repo.
Unfortunately I don't have access to the computer at the moment, so can't verify that is the build error. But looking at the changes, there are a lot of unescaped apostrophes. Also line 49 should probably have %s similar to next lines.
This is a debug message and it can be ignored by clicking Ok. |
|
Many thanks for your answers 👍. Build ran with success on my repo ✅. |
|
Hi, I commited my changes on my "dev" branch. Resources
|
|
Full logs are visible only to the owner, so can't access them unfortunately. Can you paste part of the log with the error here or attach a screen? Looking at line 406 at dev branch, doesn't see any thing suspicious. Also please make sure that you are selecting correct branch for the build, because ldmpub-fr-review-2 branch still contains unescaped apostrophes. Also changes to your dev branch are not visible in this PR, because it is opened for the ldmpub-fr-review-2 branch. In order to merge all changes into original repo, it would be needed either to apply all required changes to the ldmpub-fr-review-2 branch (preferred way), or open another PR from your dev branch to original dev branch. |
I will try to give you the rights ...
Yes, everything is clear about branches + build process for me and ... the building job is working again🥳.
I will handle this point later. |
|
I have added your user to my repo, can you please (if your current rights are OK):
Question about the workflow process:
(1) a test job is automatically triggered after each commit and they are 7+ minutes looong |
|
Last subject for today: can you improve logs for the subtask "Build" on "Build" job? Note: performing translation using Weblate can greatly help us 😉 |

Stop at line 306
<!-- Settings -->For reference: first PR was #417