Skip to content

Conversation

@ldmpub
Copy link

@ldmpub ldmpub commented Jan 4, 2026

Stop at line 306
<!-- Settings -->

For reference: first PR was #417

@ldmpub ldmpub changed the title French Review part 2 of n (n unknown 🤣) [French Translation] Part 2 of n (n is unknown 🤣) Jan 4, 2026
Just review not going ahead ...
@ldmpub ldmpub closed this Jan 4, 2026
@ldmpub ldmpub deleted the ldmpub-fr-review-2 branch January 4, 2026 17:48
@ldmpub ldmpub restored the ldmpub-fr-review-2 branch January 4, 2026 17:58
@ldmpub
Copy link
Author

ldmpub commented Jan 4, 2026

Note for myself
PR automatically closed after branch renamed from ldmpub-fr-review-2 to ldmpub-fr-review ; then branch / old name restored => no data loss but this PR remains "closed" 😕.

@Razeeman Razeeman reopened this Jan 5, 2026
@Razeeman
Copy link
Owner

Razeeman commented Jan 5, 2026

Cont from #417 (comment)

Thanks a lot for your detailed review of this Merge Request 🙏.

Several general remarks:

  1. french translation of the app is yet of poor quality despite your awareness
  2. to ease and improve translation you may have a look to online translation tools. I personally strongly recommend using Weblate (link to my profile) ; Weblate offers a "free hosted solution" for FOSS project and is quite easy to operate with GitHub
  3. Question: is there a quick and easy way to get an updated apk to check new translations in context running the app?
  4. Personally, and since several years !, I'm trying to find an Android app to track my time during "my business" ... I will give this app a try during Q1 2026 but I already miss an easy way to track "vacation days".
  1. Agree, I used Google Translate for a lot of strings, so it's not good.
  2. Weblate would be great, need to look into it.
  3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash.
  4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it.

@ldmpub
Copy link
Author

ldmpub commented Jan 5, 2026

Hi,

Regarding your answer: "3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash."

3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think?
3.2 At https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml, I can not see how to run the workflow (it looks like this job has never been launched before), do I miss something / an authorization in the current repo ? In my own repo the job failed to run => see

@ldmpub
Copy link
Author

ldmpub commented Jan 5, 2026

Regarding answer "4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it."
That's what I'm doing but I need to work more on my knowledge of the app to change tracking units depending on activities (track Work duration is in minutes, track Vacation duration should be in Days)

@Razeeman
Copy link
Owner

Razeeman commented Jan 7, 2026

3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think?

Would be cool, unfortunately I don't know if Android development tools has this kind of automation.

3.2 At https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml, I can not see how to run the workflow (it looks like this job has never been launched before), do I miss something / an authorization in the current repo ? In my own repo the job failed to run => see

It hasn't been run for a long time, and got broken, and was failing. Should be working now in dev branch. After the successful run, there will be an artifact available for download.

That's what I'm doing but I need to work more on my knowledge of the app to change tracking units depending on activities (track Work duration is in minutes, track Vacation duration should be in Days)

There is a duration format option, but it is global for all activities unfortunately.

@Razeeman
Copy link
Owner

Razeeman commented Jan 7, 2026

Also can I mention you in the app as a translator and what name should be used for this?

@ldmpub
Copy link
Author

ldmpub commented Jan 7, 2026

Also can I mention you in the app as a translator and what name should be used for this?

No mention yet before I have performed a full review of the app translation and before I become, hopefully, a daily user of the app🤞.

@ldmpub
Copy link
Author

ldmpub commented Jan 7, 2026

3.2 At https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml, I can not see how to run the workflow (it looks like this job has never been launched before), do I miss something / an authorization in the current repo ? In my own repo the job failed to run => see

It hasn't been run for a long time, and got broken, and was failing. Should be working now in dev branch. After the successful run, there will be an artifact available for download.

Current Status:

  1. ❌ I'm still not able to run the job in "official repo" https://github.com/Razeeman/Android-SimpleTimeTracker => I can not find the button "Run workflow"
  2. ❌ In my repo (after update) the build job fails too (but a (little) good news: it ran longer 😉)
    Can you please confirm the repo where I should run the job "Build"?
  3. ❌ I installed your newly generated apk, yet at launch it returns the following error (tested on 2 smartphones)
    Screenshot_20260107_075105_Debug Simple Time Tracker

ldmpub added 2 commits January 7, 2026 08:13
'balise' replaced by 'étiquette' ... brut (but yet manual 😉) search and replace.
Updated French strings for better clarity and consistency.
@Razeeman
Copy link
Owner

Razeeman commented Jan 7, 2026

I'm still not able to run the job in "official repo" https://github.com/Razeeman/Android-SimpleTimeTracker => I can not find the button "Run workflow"

Sorry for the confusion, it should be run from your repo.

In my repo (after update) the build job fails too (but a (little) good news: it ran longer 😉)
Can you please confirm the repo where I should run the job "Build"?

Unfortunately I don't have access to the computer at the moment, so can't verify that is the build error. But looking at the changes, there are a lot of unescaped apostrophes. Also line 49 should probably have %s similar to next lines.

I installed your newly generated apk, yet at launch it returns the following error (tested on 2 smartphones)

This is a debug message and it can be ignored by clicking Ok.

@ldmpub
Copy link
Author

ldmpub commented Jan 7, 2026

Many thanks for your answers 👍.

Build ran with success on my repo ✅.
I will perform some tests with my new translation.

@ldmpub
Copy link
Author

ldmpub commented Jan 8, 2026

Hi,

I commited my changes on my "dev" branch.
After several corrections, there is one remaining error in the build job for translation string "settings_automated_tracking_text", could you please debug it for me?

Resources

@Razeeman
Copy link
Owner

Razeeman commented Jan 8, 2026

Full logs are visible only to the owner, so can't access them unfortunately. Can you paste part of the log with the error here or attach a screen?

Looking at line 406 at dev branch, doesn't see any thing suspicious. Also please make sure that you are selecting correct branch for the build, because ldmpub-fr-review-2 branch still contains unescaped apostrophes.

Also changes to your dev branch are not visible in this PR, because it is opened for the ldmpub-fr-review-2 branch. In order to merge all changes into original repo, it would be needed either to apply all required changes to the ldmpub-fr-review-2 branch (preferred way), or open another PR from your dev branch to original dev branch.

@ldmpub
Copy link
Author

ldmpub commented Jan 9, 2026

Full logs are visible only to the owner, so can't access them unfortunately.

I will try to give you the rights ...

Looking at line 406 at dev branch, doesn't see any thing suspicious

Yes, everything is clear about branches + build process for me and ... the building job is working again🥳.

Also changes to your dev branch are not visible in this PR

I will handle this point later.

@ldmpub
Copy link
Author

ldmpub commented Jan 9, 2026

I have added your user to my repo, can you please (if your current rights are OK):

Question about the workflow process:

  • Do I need to wait Test job ends (1) before starting a Build job? or is it possible to run Build job at anytime?

(1) a test job is automatically triggered after each commit and they are 7+ minutes looong

@ldmpub
Copy link
Author

ldmpub commented Jan 9, 2026

Last subject for today: can you improve logs for the subtask "Build" on "Build" job?
Yet it's too verbose and it's very hard to find errors for missing escape car \ before '

Note: performing translation using Weblate can greatly help us 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants