#88 Continuation: Make AcceleratedCheckouts.Configuration Sendable#274
Draft
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This was referenced Jun 11, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/applepay-configuration-environment-value
branch
3 times, most recently
from
6a7cd0d to
8467a9d
Compare
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the base branch from
kieran-osgood/swift6/storefront-sendable-cache
to
graphite-base/274
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/applepay-configuration-environment-value
branch
from
8467a9d to
96088b4
Compare
kieran-osgood-shopify
force-pushed
the
graphite-base/274
branch
from
c1ee065 to
50f73e7
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/274
to
kieran-osgood/swift6/storefront-sendable-cache
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/storefront-sendable-cache
branch
from
50f73e7 to
230c9ac
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/applepay-configuration-environment-value
branch
from
96088b4 to
a57ebf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
This is an optional, but encouraged step towards API consistency and preventing future incompatibility issues, following on from #88.
#88 migrated the Customer from ObservableObject to struct, so that internal app wiring was simpler.
#274 makes the parent objects of Customer (Configuration -> AcceleratedCheckoutsConfiguration -> Customer) all structs.
This helps simplify our library code, as well as reduce the public maintenance contract (including easing the mental overhead of understanding what the library is doing) when we are in a strict concurrency world.
Warning
This is a breaking change to the V3 API
The breaking change will mean changing two statements:
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.