PM_CASE_NODE return expr_only #770
Draft
+859
−738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jesse-shopify
force-pushed
the
tm-fix-tests
branch
from
169ed10 to
d89a9e9
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
2 times, most recently
from
a99c4eb to
b210716
Compare
jesse-shopify
force-pushed
the
tm-fix-tests
branch
from
d89a9e9 to
b61cc92
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
from
fd7f8ec to
516bdf5
Compare
jesse-shopify
force-pushed
the
tm-fix-tests
branch
from
b61cc92 to
7fda099
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
from
516bdf5 to
043efe0
Compare
amomchilov
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
2 times, most recently
from
78750e9 to
6ecfc5b
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
from
2457bc2 to
872c289
Compare
This was referenced Dec 2, 2025
Fairly significant refactor to how begin nodes are desugared
due to differences between pm_if_node and pm_unless_node, shared desugaringpath `translateIfNode` was removed this allows for removing up_cast calls for these nodes
jesse-shopify
force-pushed
the
tm-fix-tests
branch
from
7fda099 to
89da2eb
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
from
872c289 to
6736654
Compare
jesse-shopify
force-pushed
the
jj-rip-wq-with-fixed-tests
branch
from
b5cc561 to
dc7c659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.