chore: Rewrite the tests for the loadSubset to cover more clauses and operators#1426
Open
ivasilov wants to merge 2 commits intoTanStack:mainfrom
Open
chore: Rewrite the tests for the loadSubset to cover more clauses and operators#1426ivasilov wants to merge 2 commits intoTanStack:mainfrom
ivasilov wants to merge 2 commits intoTanStack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Rewrote and added more tests for
on-demandsync mode.I was motivated by a regression in the INNER JOIN clause where it used to take 2 queries (one for each collection) but now it takes 3 queries on v0.6.
✅ Checklist
pnpm test.🚀 Release Impact