Delay/retain input capabilities for specific outputs#738
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom Feb 7, 2026
Merged
Delay/retain input capabilities for specific outputs#738frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom
Conversation
This PR implements various ergonomic improvements around capabilities and integration with outputs. Specifically, it makes the output port explicit, where previously one had to remember the order in which outputs were constructed. Changes the API on input capabilities such that retain/delay always takes an output port. Adds a function to outputs to determine their port. Removes functions that would always use port 0 as it is confusing in multi-output operators. Retain does not move the input capability anymore. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements various ergonomic improvements around capabilities and integration with outputs. Specifically, it makes the output port explicit, where previously one had to remember the order in which outputs were constructed.
Changes the API on input capabilities such that retain/delay always takes an output port. Adds a function to outputs to determine their port. Removes functions that would always use port 0 as it is confusing in multi-output operators. Retain does not move the input capability anymore.