[NFC] Optimize ModuleUtils type-scanning code#8572
Open
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Open
[NFC] Optimize ModuleUtils type-scanning code#8572kripken wants to merge 2 commits intoWebAssembly:mainfrom
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we always did a loop on
type.getHeapTypeChildren()whichmeans setting up a scanner object and going through a generic
path. Instead, handle the common cases directly. This avoids any
generic path in the common case.
This makes us 1% faster on
-O3, as measured by instructioncount, number of branches, and walltime. The noise in the first
two is incredibly small, so this looks reliably faster.