Skip to content

[NFC] Optimize ModuleUtils type-scanning code #8572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kripken wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[NFC] Optimize ModuleUtils type-scanning code #8572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d40f9d4
go
kripken Apr 3, 2026
b3a3309
fast
kripken Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/ir/module-utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,15 @@ struct TypeInfos {
}
}
void note(Type type) {
for (HeapType ht : type.getHeapTypeChildren()) {
note(ht);
// Handle the common case of a ref directly, to avoid a scan of children.
if (type.isRef()) {
note(type.getHeapType());
return;
}
if (type.isTuple()) {
for (HeapType ht : type.getHeapTypeChildren()) {
note(ht);
}
}
}
// Ensure a type is included without increasing its count.
Expand All @@ -374,8 +381,14 @@ struct TypeInfos {
}
}
void include(Type type) {
for (HeapType ht : type.getHeapTypeChildren()) {
include(ht);
if (type.isRef()) {
include(type.getHeapType());
return;
}
if (type.isTuple()) {
for (HeapType ht : type.getHeapTypeChildren()) {
include(ht);
}
}
}
void noteControlFlow(Signature sig) {
Expand Down
Loading