-
Notifications
You must be signed in to change notification settings - Fork 47
Add CI workflow for JS unit tests #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #250 +/- ##
============================================
- Coverage 10.97% 10.54% -0.43%
Complexity 4284 4284
============================================
Files 266 279 +13
Lines 33139 34576 +1437
============================================
+ Hits 3636 3645 +9
- Misses 29503 30931 +1428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40f1336 to
5244233
Compare
5244233 to
47eedd5
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it.
|
We may need it to rebase, as I fixed the Placeholder error a while ago. |
|
Yes, this branch needs updating with trunk and fixing some tests yet, I'll do it to help with the coverage in #253 (although it should not be a blocker for that PR) |
509794a to
bfcf4e8
Compare
|
@cbravobernal the JS failing test is fixed now; feel free to manually test and rebase #253 🚀 |
What
Improves the project's CI to run JS unit tests in PRs and pushes to trunk.
Why
JS unit tests were recently added to the project, so it's good that we run them as part of the CI.
How