Feature: Add binding connector to the site editor. #253

cbravobernal · 2025-11-24T15:33:28Z

What

Adds the ability to connect paragraphs and images to custom fields in the site editor. Enhancing the creation of custom templates for custom post types with custom fields.

Screenshare

SCF-edit.mp4

It needs

The field group must have REST API enabled.
Fields must have Block Bindings setting enabled.

codecov · 2025-11-24T15:34:33Z

Codecov Report

❌ Patch coverage is 96.01770% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.51%. Comparing base (53b7351) to head (70fe014).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ncludes/rest-api/class-acf-rest-types-endpoint.php	76.00%	6 Missing ⚠️
assets/src/js/bindings/sources.js	90.47%	2 Missing ⚠️
assets/src/js/bindings/hooks.js	98.46%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk     #253      +/-   ##
============================================
+ Coverage     10.54%   11.51%   +0.96%     
- Complexity     4284     4285       +1     
============================================
  Files           279      284       +5     
  Lines         34576    34697     +121     
============================================
+ Hits           3647     3994     +347     
+ Misses        30929    30703     -226

Flag	Coverage Δ
e2e	`30.68% <64.17%> (+1.09%)`	⬆️
javascript	`2.53% <90.54%> (+2.27%)`	⬆️
phpunit	`6.63% <76.00%> (+0.57%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR adds a binding connector feature for the site editor, enabling users to connect block attributes (paragraphs, headings, images, buttons) to custom fields when creating custom templates for custom post types.

Key Changes:

Refactored REST API endpoint for better maintainability and removed feature flag gate
Added comprehensive JavaScript infrastructure for block bindings (store, hooks, utilities, field processing)
Implemented site editor vs post editor context awareness with appropriate field handling

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`includes/rest-api/class-acf-rest-types-endpoint.php`	Refactored with constants, helper methods, improved validation, and added field name to REST response
`assets/src/js/bindings/utils.js`	New utility functions for field filtering, type checking, template parsing, and data formatting
`assets/src/js/bindings/store.js`	New Redux store for managing field metadata across block bindings
`assets/src/js/bindings/sources.js`	Refactored binding source with site editor support and field label placeholders
`assets/src/js/bindings/index.js`	Updated imports to include new store module
`assets/src/js/bindings/hooks.js`	Custom React hooks for site editor context, field fetching, and binding state management
`assets/src/js/bindings/field-processing.js`	Extracted field processing logic for better code organization and reusability
`assets/src/js/bindings/constants.js`	Configuration defining which field types bind to which block attributes
`assets/src/js/bindings/block-editor.js`	Refactored block controls using new hooks and utilities for cleaner code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

includes/rest-api/class-acf-rest-types-endpoint.php

assets/src/js/bindings/hooks.js

cbravobernal · 2025-12-01T12:33:11Z

Codecov seems not to be reading correctly the coverage. As assets/src/js/bindings/field-processing.jsis 100% covered and is saying it is at 0 😕

github-actions · 2025-12-01T12:34:15Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props cbravobernal, priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

priethor · 2025-12-10T11:00:13Z

Codecov seems not to be reading correctly the coverage. As assets/src/js/bindings/field-processing.jsis 100% covered and is saying it is at 0 😕

That's expected; that test is a JS unit test, not e2e, and CI still doesn't run JS tests until #250 is merged (which also includes coverage tracking for JS tests)

priethor

Late to the party; works as expected 🚀

Please note that after this PR, e2e tests are broken for WP 6.2 in trunk.

priethor · 2025-12-10T17:19:12Z

tests/e2e/block-bindings-site-editor.spec.ts

+		await page.waitForTimeout(2000); // Give the editor a moment to fully load
+
+		// Close the welcome guide modal if it appears by pressing Escape
+		await page.keyboard.press( 'Escape' );
+		await page.waitForTimeout( 500 );


Wouldn't the frameLocator wait anyway without the waitForTimeout? What's the benefit of adding these hardcoded timeouts?

priethor · 2025-12-10T17:19:31Z

assets/src/js/bindings/hooks.js

+		};
+	}, [ postType ] );
+
+	return { fields, isLoading, error };


Is error shown anywhere?

priethor · 2025-12-10T17:22:39Z

tests/php/includes/rest-api/test-rest-types-endpoint.php

+	public function test_get_scf_fields() {
+		$post_type_object = array( 'slug' => 'post' );
+
+		$fields = $this->endpoint->get_scf_fields( $post_type_object );


Side note, not from this PR, but I just realized get_scf_fields doesn't take into account show_in_rest; is this expected behavior?

As far as I remember, is on purpose, so that way showing the selector on the sidebar does not depend on them. But we could make it restrictive.

priethor · 2025-12-10T18:32:18Z

Followed up with #279 to skip bindings e2e tests in WP versions < 6.5

cbravobernal self-assigned this Nov 24, 2025

cbravobernal requested review from Copilot and priethor and removed request for Copilot November 24, 2025 15:33

cbravobernal added the [Type] Enhancement New feature or request label Nov 24, 2025

cbravobernal added this to the 6.7.0 milestone Nov 24, 2025

Copilot started reviewing on behalf of cbravobernal November 24, 2025 15:34 View session

Copilot finished reviewing on behalf of cbravobernal November 24, 2025 15:37

Copilot AI reviewed Nov 24, 2025

View reviewed changes

includes/rest-api/class-acf-rest-types-endpoint.php Show resolved Hide resolved

assets/src/js/bindings/hooks.js Outdated Show resolved Hide resolved

cbravobernal marked this pull request as ready for review December 1, 2025 12:34

cbravobernal modified the milestones: 6.7.0, 6.7.1 Dec 2, 2025

priethor mentioned this pull request Dec 10, 2025

Add CI workflow for JS unit tests #250

Merged

cbravobernal force-pushed the feature/add-binding-connector-site-editor branch from 42c0413 to 069d849 Compare December 10, 2025 15:20

cbravobernal added 11 commits December 10, 2025 16:47

Initial vibe coded commit

77c2e28

Fix some post vibed coded

9496090

More small imrpovementes

df6aea5

Address copilot review

d94e8c0

Fix phpstan

1df605d

Add testing, some refactor

b6feb4d

Remove store call

b5e9737

Update e2e

9d16277

Fix CI?

64bfea9

Close first site popup

64b02c7

Fix error boundary

3cd165b

cbravobernal force-pushed the feature/add-binding-connector-site-editor branch from 069d849 to 3cd165b Compare December 10, 2025 15:50

Fix placeholder

70fe014

cbravobernal merged commit 5a894f5 into trunk Dec 10, 2025
9 checks passed

cbravobernal deleted the feature/add-binding-connector-site-editor branch December 10, 2025 16:35

priethor reviewed Dec 10, 2025

View reviewed changes

priethor modified the milestones: 6.7.1, 6.8 Dec 10, 2025

Feature: Add binding connector to the site editor. #253

Feature: Add binding connector to the site editor. #253

Uh oh!

Conversation

cbravobernal commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Screenshare

It needs

Uh oh!

codecov bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

cbravobernal commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priethor commented Dec 10, 2025

Uh oh!

Uh oh!

priethor left a comment

Choose a reason for hiding this comment

Uh oh!

priethor Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

priethor Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

priethor Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

cbravobernal Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

priethor commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cbravobernal commented Nov 24, 2025 •

edited

Loading

codecov bot commented Nov 24, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading