refactor(@ngtools/webpack): support optional baseUrl with tsconfig paths#32646
Merged
clydin merged 1 commit intoangular:mainfrom Mar 2, 2026
Merged
refactor(@ngtools/webpack): support optional baseUrl with tsconfig paths#32646clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
clydin
force-pushed
the
webpack/paths-base-url
branch
from
df88ffe to
da0d775
Compare
The Webpack plugin now ensures a `baseUrl` is set when `paths` are present, using the `pathsBasePath` as a fallback. This makes the `baseUrl` property optional in `tsconfig.json` files when `paths` are used. This commit also refactors several tests to remove their reliance on a pre-existing `baseUrl`. The tests now programmatically add `paths` to the `tsconfig.json` to avoid brittle string replacements. The test project's base `tsconfig.json` has also been updated to remove the now optional `baseUrl`.
clydin
force-pushed
the
webpack/paths-base-url
branch
from
da0d775 to
83e9d35
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 2, 2026
alan-agius4
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Webpack plugin now ensures a
baseUrlis set whenpathsare present, using thepathsBasePathas a fallback. This makes thebaseUrlproperty optional intsconfig.jsonfiles whenpathsare used.This commit also refactors several tests to remove their reliance on a pre-existing
baseUrl. The tests now programmatically addpathsto thetsconfig.jsonto avoid brittle string replacements. The test project's basetsconfig.jsonhas also been updated to remove the now optionalbaseUrl.