Skip to content

refactor(@ngtools/webpack): support optional baseUrl with tsconfig paths #32646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Mar 2, 2026
Merged

refactor(@ngtools/webpack): support optional baseUrl with tsconfig paths #32646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/testing/builder/projects/hello-world-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist/out-tsc",
"sourceMap": true,
"declaration": false,
Expand Down
2 changes: 1 addition & 1 deletion ...ges/angular/build/src/builders/application/tests/behavior/typescript-path-mapping_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
await harness.modifyFile('tsconfig.json', (content) => {
const tsconfig = JSON.parse(content);
tsconfig.compilerOptions.paths = {
'app-module': ['a.js'],
'app-module': ['./a.js'],
};

return JSON.stringify(tsconfig);
Expand Down
18 changes: 7 additions & 11 deletions ...gular/build/src/builders/application/tests/options/allowed-common-js-dependencies_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,13 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {

it('should not show warning in JIT for templateUrl and styleUrl when using paths', async () => {
await harness.modifyFile('tsconfig.json', (content) => {
return content.replace(
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"@app/*": [
"src/app/*"
]
},
`,
);
const tsconfig = JSON.parse(content);
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'@app/*': ['./src/app/*'],
};

return JSON.stringify(tsconfig, null, 2);
});

await harness.modifyFile('src/app/app.module.ts', (content) =>
Expand Down
22 changes: 9 additions & 13 deletions packages/angular/build/src/builders/karma/tests/options/code-coverage_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,15 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
}
`,
});
await harness.modifyFile('tsconfig.json', (content) =>
content.replace(
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"my-lib": [
"./dist/my-lib"
]
},
`,
),
);
await harness.modifyFile('tsconfig.json', (content) => {
const tsconfig = JSON.parse(content);
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'my-lib': ['./dist/my-lib'],
};

return JSON.stringify(tsconfig, null, 2);
});

harness.useTarget('test', {
...BASE_OPTIONS,
Expand Down
53 changes: 22 additions & 31 deletions packages/angular_devkit/build_angular/src/builders/browser/specs/tsconfig-paths_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

import { Architect } from '@angular-devkit/architect';
import { normalize, virtualFs } from '@angular-devkit/core';
import { browserBuild, createArchitect, host } from '../../../testing/test-utils';

describe('Browser Builder tsconfig paths', () => {
Expand All @@ -21,18 +22,16 @@ describe('Browser Builder tsconfig paths', () => {

it('should resolve basic tsconfig paths', async () => {
host.replaceInFile('src/app/app.module.ts', './app.component', '@root/app/app.component');
host.replaceInFile(
'tsconfig.json',
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"@root/*": [
"./src/*"
]
},
`,
);

const tsconfigPath = normalize('tsconfig.json');
const tsconfig = JSON.parse(virtualFs.fileBufferToString(host.scopedSync().read(tsconfigPath)));
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'@root/*': ['./src/*'],
};
host
.scopedSync()
.write(tsconfigPath, virtualFs.stringToFileBuffer(JSON.stringify(tsconfig, null, 2)));

await browserBuild(architect, host, target);
});
Expand All @@ -43,25 +42,17 @@ describe('Browser Builder tsconfig paths', () => {
'src/app/shared/meaning.ts': 'export var meaning = 42;',
'src/app/shared/index.ts': `export * from './meaning'`,
});
host.replaceInFile(
'tsconfig.json',
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"@shared": [
"src/app/shared"
],
"@shared/*": [
"src/app/shared/*"
],
"*": [
"*",
"src/app/shared/*"
]
},
`,
);
const tsconfigPath = normalize('tsconfig.json');
const tsconfig = JSON.parse(virtualFs.fileBufferToString(host.scopedSync().read(tsconfigPath)));
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'@shared': ['src/app/shared'],
'@shared/*': ['src/app/shared/*'],
'*': ['*', 'src/app/shared/*'],
};
host
.scopedSync()
.write(tsconfigPath, virtualFs.stringToFileBuffer(JSON.stringify(tsconfig, null, 2)));
host.appendToFile(
'src/app/app.component.ts',
`
Expand Down
18 changes: 7 additions & 11 deletions ...t/build_angular/src/builders/browser/tests/options/allowed-common-js-dependencies_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,13 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {

it('should not show warning in JIT for templateUrl and styleUrl when using paths', async () => {
await harness.modifyFile('tsconfig.json', (content) => {
return content.replace(
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"@app/*": [
"src/app/*"
]
},
`,
);
const tsconfig = JSON.parse(content);
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'@app/*': ['src/app/*'],
};

return JSON.stringify(tsconfig, null, 2);
});

await harness.modifyFile('src/app/app.module.ts', (content) =>
Expand Down
22 changes: 9 additions & 13 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,15 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
}
`,
});
await harness.modifyFile('tsconfig.json', (content) =>
content.replace(
/"baseUrl": ".\/",/,
`
"baseUrl": "./",
"paths": {
"my-lib": [
"./dist/my-lib"
]
},
`,
),
);
await harness.modifyFile('tsconfig.json', (content) => {
const tsconfig = JSON.parse(content);
tsconfig.compilerOptions ??= {};
tsconfig.compilerOptions.paths = {
'my-lib': ['./dist/my-lib'],
};

return JSON.stringify(tsconfig, null, 2);
});

harness.useTarget('test', {
...BASE_OPTIONS,
Expand Down
1 change: 1 addition & 0 deletions packages/ngtools/webpack/src/ivy/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ export class AngularWebpackPlugin {
this.pluginOptions.tsconfig,
this.pluginOptions.compilerOptions,
);
compilerOptions.baseUrl ??= compilerOptions['pathsBasePath'];
compilerOptions.composite = false;
compilerOptions.noEmitOnError = false;
compilerOptions.suppressOutputPathCheck = true;
Expand Down