Skip to content

THRIFT-5923: UUID python#3330

Closed
CJCombrink wants to merge 14 commits intoapache:masterfrom
CJCombrink:uuid_python
Closed

THRIFT-5923: UUID python#3330
CJCombrink wants to merge 14 commits intoapache:masterfrom
CJCombrink:uuid_python

Conversation

@CJCombrink
Copy link
Contributor

@CJCombrink CJCombrink commented Mar 4, 2026

Add UUID support for Python

  • Did you create an Apache Jira ticket? THRIFT-5923: UUID support for Python
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable bot added c++ python github_actions Pull requests that update GitHub Actions code labels Mar 4, 2026
CJCombrink
CJCombrink commented Mar 4, 2026
View reviewed changes
CJCombrink
CJCombrink commented Mar 4, 2026
View reviewed changes
lib/py/src/Thrift.py Outdated
LIST = 15
UTF8 = 16
UTF16 = 17
UTF8 = 11
Copy link
Contributor Author

@CJCombrink CJCombrink Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to my other comment, same applies here

@CJCombrink CJCombrink mentioned this pull request Mar 6, 2026
Open
5 tasks
@Jens-G
Copy link
Member

Jens-G commented Mar 10, 2026 

Total Test time (real) = 175.72 sec
The following tests FAILED:
	 57 - python_test (Failed)
Errors while running CTest
Output from these tests are in: C:/projects/build/MSVC2022/x64/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
C:\projects\thrift>set lastexitcode=8

CJCombrink added 14 commits March 11, 2026 05:29
@CJCombrink
Starting to add UUID support for Python
a0538ae
@CJCombrink
Remove commented out code and duplicate call to make
4dc64f7
@CJCombrink
Update script to detect changes and handle failures more consistent
64c7ee0 
- Correctly fail with error code when there are errors so that cmake/make fails
- Set up dependencies so that changes are built for any affected file
@CJCombrink
Implement compact protocol
03cead1
@CJCombrink
Further implement and fix UUID support for thrift
e0b04a6 
- Tested against itself and C++ to start with
   - Cleaned out known_failures (some had unsupported protocols even)
@CJCombrink
Sneak in skip UUID for C++
dbc7dd5
@CJCombrink
Clean up and optimise the UUID reading and writing
eb960d7 
- RAII wrappers to prevent leaks
- Optimisze with INTERN_STRING
@CJCombrink
Fix options in test
1d58af7
@CJCombrink
Combine go,cpp,py tests
e314cfc 
- Clean out known failures between go and py
- Appears there is some ssl issue for some of the tests
@CJCombrink
Mark UUID as supported in the LANGAUGES page
5f839dc
@CJCombrink
Remove UTF8 and UTF16 as discussed in PR
c3f9578 
- It is not in the spec and string can be used
@CJCombrink
Flake8 findings
422000e 
- Probably found a buf in the JSON protocol
@CJCombrink
More flake8 fixes
dfec76d
@CJCombrink
Fix failing python unit tests
aaef428 
- Missed a few v0.16 for cmake
@CJCombrink
Copy link
Contributor Author

CJCombrink commented Mar 11, 2026

@Jens-G Thanks, I always forget about the cmake side

Should be fixed now if you can please trigger the builds

@Jens-G Jens-G closed this in a715bdf Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jens-G Jens-G Jens-G left review comments

Assignees

No one assigned

Labels

c++ github_actions Pull requests that update GitHub Actions code python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CJCombrink @Jens-G