Skip to content

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Feb 11, 2026

Mark the following tests with @pytest.mark.run_alone so they run in isolation (numprocesses=1) rather than in parallel, reducing flakiness observed across the last ~10 master commits.

Mark the following tests with `@pytest.mark.run_alone` so they run in
isolation (numprocesses=1) rather than in parallel, reducing flakiness
observed across the last 10 master commits:

- test_open_and_close_page (failed on Windows)
- test_get_cpu_sample (failed on Windows)
- test_snapshot_pruning_removes_outdated_records (failed on Ubuntu)
- test_execution in test_recurring_task (upgraded from run_alone_on_mac
  to full run_alone, failed on macOS)

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@vdusek vdusek self-assigned this Feb 11, 2026
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Feb 11, 2026
@github-actions github-actions bot added this to the 134th sprint - Tooling team milestone Feb 11, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 11, 2026
The test fails with `assert 3 == 2` even when running in isolation,
indicating a real bug in snapshot pruning boundary logic rather than
a parallelism issue.

Tracked in #1734

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.49%. Comparing base (910ab54) to head (3597c0a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   92.42%   92.49%   +0.06%     
==========================================
  Files         156      156              
  Lines       10602    10602              
==========================================
+ Hits         9799     9806       +7     
+ Misses        803      796       -7     
Flag Coverage Δ
unit 92.49% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vdusek and others added 2 commits February 11, 2026 10:58
Timing-sensitive test fails when running in parallel due to CPU
contention (0.312s > 0.3s threshold).

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Flaky cookie isolation test fails intermittently when running in
parallel — cookies not propagated in time via PlaywrightContext.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@Pijukatel Pijukatel self-requested a review February 11, 2026 10:21
@pytest.mark.skip(
reason='Flaky due to snapshot pruning boundary condition, see https://github.com/apify/crawlee-python/issues/1734'
)
async def test_snapshot_pruning_removes_outdated_records(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen any flakiness after this was merged?
#1716

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see this branch was properly based on that change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in this PR

@Pijukatel Pijukatel self-requested a review February 11, 2026 10:27
@vdusek vdusek merged commit 309fb38 into master Feb 11, 2026
32 checks passed
@vdusek vdusek deleted the test/mark-flaky-tests-run-alone branch February 11, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants