Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/_autoscaling/test_autoscaled_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def future(value: T, /) -> Awaitable[T]:
return f


@pytest.mark.run_alone
async def test_runs_concurrently(system_status: SystemStatus | Mock) -> None:
done_count = 0

Expand Down
4 changes: 4 additions & 0 deletions tests/unit/_autoscaling/test_snapshotter.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ def test_snapshot_client_overloaded() -> None:
assert ClientSnapshot(error_count=7, new_error_count=3, max_error_count=2).is_overloaded


@pytest.mark.run_alone
async def test_get_cpu_sample(
snapshotter: Snapshotter, event_manager: LocalEventManager, default_memory_info: MemoryInfo
) -> None:
Expand Down Expand Up @@ -212,6 +213,9 @@ async def test_methods_raise_error_when_not_active() -> None:
assert snapshotter.active is True


@pytest.mark.skip(
reason='Flaky due to snapshot pruning boundary condition, see https://github.com/apify/crawlee-python/issues/1734'
)
async def test_snapshot_pruning_removes_outdated_records(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen any flakiness after this was merged?
#1716

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see this branch was properly based on that change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in this PR

snapshotter: Snapshotter, event_manager: LocalEventManager, default_memory_info: MemoryInfo
) -> None:
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/_utils/test_recurring_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import pytest

from crawlee._utils.recurring_task import RecurringTask
from tests.unit.utils import run_alone_on_mac


@pytest.fixture
Expand Down Expand Up @@ -42,7 +41,7 @@ async def test_start_and_stop(function: AsyncMock, delay: timedelta) -> None:
assert rt.task.done()


@run_alone_on_mac
@pytest.mark.run_alone
async def test_execution(function: AsyncMock, delay: timedelta) -> None:
task = RecurringTask(function, delay)

Expand Down
1 change: 1 addition & 0 deletions tests/unit/browsers/test_playwright_browser_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ async def test_initial_state(browser: Browser) -> None:
assert controller.has_free_capacity


@pytest.mark.run_alone
async def test_open_and_close_page(controller: PlaywrightBrowserController, server_url: URL) -> None:
page = await controller.new_page()
await page.goto(str(server_url))
Expand Down
1 change: 1 addition & 0 deletions tests/unit/crawlers/_playwright/test_playwright_crawler.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ async def some_hook(context: PlaywrightPreNavCrawlingContext) -> None:
assert handler_data.get('proxy') == proxy_value


@pytest.mark.run_alone
@pytest.mark.parametrize(
'use_incognito_pages',
[
Expand Down
Loading