fix(XMLPatch): support multiple sibling elements in replace operations#29
Closed
louga31 wants to merge 1 commit intochemodun:mainfrom
Closed
fix(XMLPatch): support multiple sibling elements in replace operations#29louga31 wants to merge 1 commit intochemodun:mainfrom
louga31 wants to merge 1 commit intochemodun:mainfrom
Conversation
The ApplyReplace method used replaceElement.Element(targetName) which only returned the first matching child element, silently dropping any additional siblings. This fix inserts all child elements from the replace operation, preserving their order. This is needed for X4 diff patches where a single element is replaced with multiple siblings (e.g. a do_if followed by do_elseif chains).
chemodun
reviewed
Feb 22, 2026
Owner
chemodun
left a comment
There was a problem hiding this comment.
Thanks. But excuse me, in parallel several day ago made appropriate patch for the both utils.
Currently have possibility to publish it.
One more time thank and excuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplyReplaceusedreplaceElement.Element(targetName)which only returns the first matching child element, silently dropping any additional siblings<replace>operation, preserving their order"and 3 sibling(s)")Problem
When a
<replace>diff operation contains multiple sibling elements:Only the first
<do_if>was inserted — the<do_elseif>elements were silently dropped. This is a valid pattern in X4 diff patches where a single element is replaced with an if/elseif chain.Fix
Instead of
replaceElement.Element(targetName)(single element), the fix usesreplaceElement.Elements().ToList()to collect all children, then inserts them in order usingAddAfterSelfbefore removing the original target.Test plan
<replace>operations