Skip to content

fix(XMLPatch): support multiple sibling elements in replace operations #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
louga31 wants to merge 1 commit into from
Closed

fix(XMLPatch): support multiple sibling elements in replace operations #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions XMLPatch/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,16 +592,21 @@ private void ApplyReplace(XElement replaceElement, XElement originalRoot)
{
if (targetObj is XElement target)
{
string targetName = target.Name.LocalName;
XElement? replaceSubElement = replaceElement.Element(targetName);
var replaceChildren = replaceElement.Elements().ToList();
XElement? parent = target.Parent;
string targetInfo = GetElementInfo(target);
string parentInfo = GetElementInfo(parent);
if (replaceSubElement != null)
if (replaceChildren.Count > 0)
{
string replaceInfo = GetElementInfo(replaceSubElement);
target.ReplaceWith(replaceSubElement);
Logger.Info($"Replaced element '{targetInfo}' with '{replaceInfo}' in '{parentInfo}'.");
// Insert all child elements from the replace operation
XNode lastInserted = target;
for (int i = replaceChildren.Count - 1; i >= 0; i--)
{
target.AddAfterSelf(replaceChildren[i]);
}
target.Remove();
string replaceInfo = GetElementInfo(replaceChildren[0]);
Logger.Info($"Replaced element '{targetInfo}' with '{replaceInfo}'{(replaceChildren.Count > 1 ? $" and {replaceChildren.Count - 1} sibling(s)" : "")} in '{parentInfo}'.");
}
else
{
Expand Down