Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coder updatesubprocess with an API update path.Fixes #939.
Tests
pnpm test:extension ./test/unit/api/workspace.test.ts ./test/unit/remote/workspaceStateMachine.test.tspnpm typecheckpnpm lintpnpm format:checkSupporting plan and decision context
The issue is caused by
coder updateprompting for parameter values while the extension streams CLI output to a read-only VS CodeOutputChannel.Chosen approach: replace only the update subprocess with API calls, preserving the existing reload-before-update flow. The updater fetches a fresh workspace, fetches previous build parameters and target template parameters, computes prompt-worthy parameters using dashboard-style logic, collects those values with VS Code prompts before stopping the workspace, starts the active template version with only the prompted values, waits for the build, and returns the fresh workspace.
Prompt-worthy parameters are:
Rejected alternatives:
coder update --use-parameter-defaults: only available in newer CLI versions and would not support required parameters without defaults.Caveat: full dynamic-parameter editing inside VS Code would require a richer webview and dynamic evaluation flow. This PR keeps the UI lightweight and still relies on backend validation for final correctness.
Generated by Coder Agents.