ci: always run Node.js integration tests on PR/merge (covers GA Thrift)#443
Merged
Merged
Conversation
The dispatched databricks-driver-test suite runs a backend matrix — thrift (blocking), sea/normal (blocking), sea/reyden (non-blocking) — so it gates the GA Thrift path as well as SEA/kernel. Gating the dispatch on a kernel/source path allow-list meant changes outside that list (incl. KERNEL_REV bumps and native/ binding edits) skipped the suite even though they can affect the Thrift leg, and the merge-queue gate auto-passed green without running anything. Drop the path-based gating in both the merge-queue gate (merge-queue-nodejs) and the labeled-PR preview (trigger-tests-pr) so the suite runs on every merge-queue commit and every labeled PR. driver-test builds the napi binding from the driver's KERNEL_REV at the dispatched commit, so the merge-queue run exercises the pinned kernel version. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
msrathore-db
force-pushed
the
msrathore/mq-integration-kernel-rev
branch
from
73fb2a5 to
bb42caf
Compare
msrathore-db
changed the title
msrathore-db
added
the
integration-test
|
Node.js integration tests triggered. View workflow run. |
sreekanth-db
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the Node.js integration suite run on every merge-queue commit and every labeled PR, instead of gating the dispatch on a kernel/source path allow-list. Drops the path-based change-detection in both jobs of
trigger-integration-tests.yml:merge-queue-nodejs(the required merge-queue gate)trigger-tests-pr(theintegration-test-labeled PR preview)Why
The dispatched
databricks-driver-testsuite runs a backend matrix:thrift / normal— blocking gate (the GA path)sea / normal— blocking gatesea / reyden— non-blocking (surfaces Reyden server-side limitations)Because it gates the GA Thrift backend too, virtually any change in this repo can affect it. The previous path allow-list (
bin/ lib/ spec/ thrift/ tests/e2e/ tests/integration/ package*.json tsconfig* .github/workflows/) meant:KERNEL_REVbumps andnative/binding changes were classified "no driver changes" → the requiredNode.js Integration Testscheck auto-passed green without running — exactly the PRs that swap the pinned kernel.driver-test already builds the napi binding from this repo's
KERNEL_REVat the dispatched commit (readsKERNEL_REV→ checks outdatabricks-sql-kernelat that SHA →build:native), so the merge-queue run exercises the pinned kernel version. This PR just ensures the dispatch always happens.Change
Both jobs now unconditionally mark for dispatch (
changed=true/nodejs=true); the dead "no driver changes" auto-pass steps are removed. Downstreamif: … == 'true'guards and the dispatch-error handlers are unchanged. Pure CI/workflow change.This pull request and its description were written by Isaac.