chore (deps): bump go version to v1.26.4#1667
Conversation
Update Go toolchain to 1.26.4 and use Red Hat UBI9 go-toolset:9.8-1782736563 with digest sha256:35b140d3c10e19544654d1b5cc249347df7fdc136dfbce79c480bd41d6d6ea9d Signed-off-by: Rohan Kumar <rohaan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughGo toolchain version bumped from 1.26.3 to 1.26.4 across Go 1.26.4 Toolchain Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
rohanKanojia
requested review from
akurinnoy,
btjd,
dkwon17 and
ibuziuk
as code owners
|
/che-ai-assistant ok-pr-readiness Review is complete. Please check the review comments below. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.ci/oci.Dockerfile:
- Line 28: Update the comment in the Dockerfile so it matches the current source
of truth from go.mod: the stale reference to go 1.26.0 should be replaced with
the actual toolchain directive version go1.26.4. Keep the comment aligned with
the dependency/version guidance by referring to the toolchain requirement
declared in go.mod, not an old version string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b766e12d-579c-4376-9013-dc109c97e22b
📒 Files selected for processing (7)
.ci/oci.Dockerfile.github/workflows/code-coverage.yml.github/workflows/pr.yml.github/workflows/release.ymlbuild/Dockerfilego.modproject-clone/Dockerfile
| SHELL ["/bin/bash", "-c"] | ||
|
|
||
| # Install Go 1.26.3 to satisfy go.mod toolchain requirement (go 1.26.0) | ||
| # Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the stale toolchain reference in the comment.
Line 28 still says the "toolchain requirement" is go 1.26.0, but go.mod now declares toolchain go1.26.4. Please point the comment at the actual source-of-truth directive.
As per coding guidelines, "Use versions from go.mod as the source of truth for Go, Kubernetes, controller-runtime, and Devfile dependency versions."
Suggested fix
-# Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0)
+# Install Go 1.26.4 to satisfy the go.mod toolchain directive📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0) | |
| # Install Go 1.26.4 to satisfy the go.mod toolchain directive |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.ci/oci.Dockerfile at line 28, Update the comment in the Dockerfile so it
matches the current source of truth from go.mod: the stale reference to go
1.26.0 should be replaced with the actual toolchain directive version go1.26.4.
Keep the comment aligned with the dependency/version guidance by referring to
the toolchain requirement declared in go.mod, not an old version string.
Source: Coding guidelines
PR Readiness Assessment: PR #1667 — chore (deps): bump go version to v1.26.4Repository: devfile/devworkspace-operator
Overall: NEEDS WORK Missing Information
What's Good
Assessment completed by ok-pr-readiness |
2 participants
What does this PR do?
go.modtoolchain directive togo1.26.4pr.yml,code-coverage.yml,release.yml) to use Go 1.26.4.ci/oci.Dockerfileto install Go 1.26.4build/Dockerfileandproject-clone/Dockerfileto Red Hat UBI9 go-toolset9.8-1782736563pinned by digest:sha256:35b140d3c10e19544654d1b5cc249347df7fdc136dfbce79c480bd41d6d6ea9dWhat issues does this PR fix or reference?
Routine Go toolchain maintenance; no linked issue.
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit