Skip to content

chore (deps): bump go version to v1.26.4 #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohanKanojia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore (deps): bump go version to v1.26.4 #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .ci/oci.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@

FROM registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.24-openshift-4.20

ENV GO_VERSION=1.26.3
ENV GO_VERSION=1.26.4
ENV GOROOT=/usr/local/go
ENV PATH=$GOROOT/bin:$PATH

ENV GO_VERSION=1.26.3
ENV GO_VERSION=1.26.4
ENV GOROOT=/usr/local/go
ENV PATH=$GOROOT/bin:$PATH

SHELL ["/bin/bash", "-c"]

# Install Go 1.26.3 to satisfy go.mod toolchain requirement (go 1.26.0)
# Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0)

@coderabbitai coderabbitai Bot Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix the stale toolchain reference in the comment.

Line 28 still says the "toolchain requirement" is go 1.26.0, but go.mod now declares toolchain go1.26.4. Please point the comment at the actual source-of-truth directive.

As per coding guidelines, "Use versions from go.mod as the source of truth for Go, Kubernetes, controller-runtime, and Devfile dependency versions."

Suggested fix 
-# Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0)
+# Install Go 1.26.4 to satisfy the go.mod toolchain directive
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0)
# Install Go 1.26.4 to satisfy the go.mod toolchain directive
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.ci/oci.Dockerfile at line 28, Update the comment in the Dockerfile so it
matches the current source of truth from go.mod: the stale reference to go
1.26.0 should be replaced with the actual toolchain directive version go1.26.4.
Keep the comment aligned with the dependency/version guidance by referring to
the toolchain requirement declared in go.mod, not an old version string.

Source: Coding guidelines

RUN export ARCH="$(uname -m)" && if [[ ${ARCH} == "x86_64" ]]; then export ARCH="amd64"; elif [[ ${ARCH} == "aarch64" ]]; then export ARCH="arm64"; fi && \
curl -fsSL "https://go.dev/dl/go${GO_VERSION}.linux-${ARCH}.tar.gz" -o go.tar.gz && \
rm -rf /usr/local/go && \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
name: Set up Go 1.x
uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: 1.26.3
go-version: 1.26.4
-
name: Set up Python 3.11
uses: actions/setup-python@b64ffcaf5b410884ad320a9cfac8866006a109aa # v4.8.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: Set up Go 1.x
uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: 1.26.3
go-version: 1.26.4
-
name: Set up Python 3.11
uses: actions/setup-python@b64ffcaf5b410884ad320a9cfac8866006a109aa # v4.8.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: 1.26.3
go-version: 1.26.4
- name: Set up QEMU
uses: docker/setup-qemu-action@2b82ce82d56a2a04d2637cd93a637ae1b359c0a7 #v2.2.0

Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
# Use BUILDPLATFORM to ensure the builder always runs natively on the host machine
# Image pinned by SHA256 to address GitHub security bot warnings about unpinned dependencies
FROM --platform=$BUILDPLATFORM registry.access.redhat.com/ubi9/go-toolset:1.26.3-1782348382@sha256:6fdc004bff119315ee4f19363ac1dec934fc40270d9aa1e6b4fbfa2467757570 AS builder
FROM --platform=$BUILDPLATFORM registry.access.redhat.com/ubi9/go-toolset:9.8-1782736563@sha256:35b140d3c10e19544654d1b5cc249347df7fdc136dfbce79c480bd41d6d6ea9d AS builder

# Accept TARGETARCH and TARGETPLATFORM, which are automatically passed by the builder
ARG TARGETARCH
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/devfile/devworkspace-operator

go 1.26.0

toolchain go1.26.3
toolchain go1.26.4

require (
github.com/devfile/api/v2 v2.3.1-alpha.0.20250521155908-5c3d7b99d252
Expand Down
2 changes: 1 addition & 1 deletion project-clone/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# Build the manager binary
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
# Image pinned by SHA256 to address GitHub security bot warnings about unpinned dependencies
FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3-1782348382@sha256:6fdc004bff119315ee4f19363ac1dec934fc40270d9aa1e6b4fbfa2467757570 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1782736563@sha256:35b140d3c10e19544654d1b5cc249347df7fdc136dfbce79c480bd41d6d6ea9d as builder
ARG TARGETARCH
ARG TARGETOS
ENV GOPATH=/go/
Expand Down
Loading