feat: Implement enhancements for new design #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
therobrob
reviewed
Jun 14, 2025
Member
therobrob
left a comment
therobrob
left a comment
There was a problem hiding this comment.
i've some questions and comments about your suggestions. to resolve them, it seems cool to talk about it, i think :)
MoritzWeber0
force-pushed
the
feat/new-design-review
branch
from
ba78057 to
415358d
Compare
A line-clamp is more flexible for different device types and always clamps to three lines. This makes better use of the available space.
MoritzWeber0
force-pushed
the
feat/new-design-review
branch
from
415358d to
8512b59
Compare
MoritzWeber0
added
the
technical
This was referenced Jun 22, 2025
Closed
therobrob
approved these changes
Jun 22, 2025
therobrob
added a commit
that referenced
this pull request
Jul 5, 2025
Bootstrap was a good library to get started faster, but we've mostly used custom styling and most of the bootstrap functionality wasn't used. Removing bootstrap provides a few advantages: - We gain full control over the styles - Better adoption to CSS BEM (we can choose our own class names) - Reduced bundle size - Better DevTools support. Chrome and Firefox have some neat development tools around grid layout. The devtools didn't work with the bootstrap grid layout. - Less chance of breaking changes. Bootstrap is under active development and can introduce breaking changes. CSS itself is considered as rather stable. As proposed in #192 (comment), the removal of bootstrap as separate PR. Resolves #74. Beside some minor changes to margins and sizes, the most significant visual change is the style of tables, which I changed as part of this PR. --------- Co-authored-by: Robert Schuster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to split the different parts into different commits, so that we can easily take out some individual parts.